linux-kernel - Re: [PATCH v2 1/3] staging: media: max96712: fix typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <km7kpbkmdzkkuta2jlr4eql437mfkpv7oeeub4iajqex3na4vr@hqyapkdocyzp>
Date: Fri, 20 Dec 2024 13:09:59 +0200
From: Laurentiu Palcu <laurentiu.palcu@....nxp.com>
To: Niklas Söderlund <niklas.soderlund@...natech.se>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org, linux-media@...r.kernel.org, 
	linux-staging@...ts.linux.dev
Subject: Re: [PATCH v2 1/3] staging: media: max96712: fix typo

Hi Niklas,

On Fri, Dec 20, 2024 at 11:59:34AM +0100, Niklas Söderlund wrote:
> Hi Laurentiu,
> 
> On 2024-12-20 12:49:36 +0200, Laurentiu Palcu wrote:
> > Fix a typo in VS_LOW expression.
> > 
> > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@....nxp.com>
> > Reviewed-by: Niklas S??derlund <niklas.soderlund+renesas@...natech.se>
> 
> I think your mail setup mangled my döts ;-) The Content-Type header for 
> this mail is set to 'text/plain; charset="us-ascii"' while the patch is 
> likely utf-8 encoded. Same in patch 3/3.

Sorry about that. I didn't mean to mess-up your name... :/ Apparently,
this how 'git format-patch' generated the patch header:

===
>From 19c513feb2003dff89c28ef9e54c0e06929efb0a Mon Sep 17 00:00:00 2001
From: Laurentiu Palcu <laurentiu.palcu@....nxp.com>
Date: Thu, 19 Dec 2024 09:28:54 +0000
Subject: [PATCH v2 1/3] staging: media: max96712: fix typo
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="us-ascii"
===

It looks like it generated 2 Content-Type lines. And the last one
took precedence... 

Looks like a git bug?!? I'm no expert in this area though.

Thanks,
Laurentiu

> 
> > ---
> >  drivers/staging/media/max96712/max96712.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/media/max96712/max96712.c b/drivers/staging/media/max96712/max96712.c
> > index 0751b2e048958..5228f9ec60859 100644
> > --- a/drivers/staging/media/max96712/max96712.c
> > +++ b/drivers/staging/media/max96712/max96712.c
> > @@ -182,7 +182,7 @@ static void max96712_pattern_enable(struct max96712_priv *priv, bool enable)
> >  	max96712_write_bulk_value(priv, 0x1052, 0, 3);
> >  	max96712_write_bulk_value(priv, 0x1055, v_sw * h_tot, 3);
> >  	max96712_write_bulk_value(priv, 0x1058,
> > -				  (v_active + v_fp + + v_bp) * h_tot, 3);
> > +				  (v_active + v_fp + v_bp) * h_tot, 3);
> >  	max96712_write_bulk_value(priv, 0x105b, 0, 3);
> >  	max96712_write_bulk_value(priv, 0x105e, h_sw, 2);
> >  	max96712_write_bulk_value(priv, 0x1060, h_active + h_fp + h_bp, 2);
> > -- 
> > 2.34.1
> > 
> 
> -- 
> Kind Regards,
> Niklas Söderlund