linux-kernel - Re: [PATCH 6/6] ext4: calculate rec_len of ".." with correct name length 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0fee3433-1255-42ab-80c6-63a1d9f9d47b@web.de>
Date: Fri, 20 Dec 2024 14:52:39 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Kemeng Shi <shikemeng@...weicloud.com>, linux-ext4@...r.kernel.org,
 Andreas Dilger <adilger.kernel@...ger.ca>, Theodore Ts'o <tytso@....edu>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 6/6] ext4: calculate rec_len of ".." with correct name
 length 2

> The rec_len of directory ".." should be ext4_dir_rec_len(2, NULL) instead
> of ext4_dir_rec_len(1, NULL). Although ext4_dir_rec_len return the same
> number either with name_len 1 or name_len 2, it's better use the right
> name_len to make code more intuitive.

Do you try to point a correctness issue out here?

How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13-rc3#n145

Regards,
Markus