linux-kernel - Re: [PATCH 06/11] mm/truncate: add folio_unmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d24ee33b-4207-4696-b878-5b2c4d47bec8@kernel.dk>
Date: Fri, 20 Dec 2024 07:16:24 -0700
From: Jens Axboe <axboe@...nel.dk>
To: "Kirill A. Shutemov" <kirill@...temov.name>
Cc: linux-mm@...ck.org, linux-fsdevel@...r.kernel.org, hannes@...xchg.org,
 clm@...a.com, linux-kernel@...r.kernel.org, willy@...radead.org,
 bfoster@...hat.com
Subject: Re: [PATCH 06/11] mm/truncate: add folio_unmap_invalidate() helper

On 12/20/24 4:13 AM, Kirill A. Shutemov wrote:
> On Fri, Dec 13, 2024 at 08:55:20AM -0700, Jens Axboe wrote:
>> @@ -629,18 +641,8 @@ int invalidate_inode_pages2_range(struct address_space *mapping,
>>  				folio_unlock(folio);
>>  				continue;
>>  			}
>> -			VM_BUG_ON_FOLIO(!folio_contains(folio, indices[i]), folio);
>>  			folio_wait_writeback(folio);
> 
> Any particular reason you drop this VM_BUG_ON_FOLIO()?

No reason at all, I think it just slipped under the radar. I've put it back
now, thanks!

-- 
Jens Axboe