linux-kernel - Re: [PATCH 6/6] sched_ext: Move built-in idle CPU selection policy to a separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z2WGMWvMN4GxyM0N@gpd3>
Date: Fri, 20 Dec 2024 15:58:57 +0100
From: Andrea Righi <arighi@...dia.com>
To: Yury Norov <yury.norov@...il.com>
Cc: Tejun Heo <tj@...nel.org>, David Vernet <void@...ifault.com>,
	Changwoo Min <changwoo@...lia.com>, Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Juri Lelli <juri.lelli@...hat.com>,
	Vincent Guittot <vincent.guittot@...aro.org>,
	Dietmar Eggemann <dietmar.eggemann@....com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
	Valentin Schneider <vschneid@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/6] sched_ext: Move built-in idle CPU selection policy
 to a separate file

On Fri, Dec 20, 2024 at 06:53:28AM -0800, Yury Norov wrote:
> On Tue, Dec 17, 2024 at 10:32:31AM +0100, Andrea Righi wrote:
> > As ext.c is becoming quite large, move the idle CPU selection policy
> > to a separate file (ext_idle.c) for better code readability.
> > 
> > No functional change, this is purely code reorganization.
> > 
> > Suggested-by: Yury Norov <yury.norov@...il.com>
> > Signed-off-by: Andrea Righi <arighi@...dia.com>
> 
> I think it should be a preparation patch at the beginning of the
> series. The one major downside of patches of that sort is that when
> moving code, you wipe git history. If you have to do that, you need
> to move code before doing the work, such that at least your updates
> will be accessible to git blame.

Right, I've already moved this at the beginning. :)

I'm re-running the usual set of tests and will likely send a new patch set
if everything looks good.

Thanks!
-Andrea