linux-kernel - Re: [PATCH] drm/panel-edp: Add support for 2 panels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=VYgzP=wG2Q6ydrs1RtC4WjB6krfh4SC2inQNpLDCy-xw@mail.gmail.com>
Date: Fri, 20 Dec 2024 07:17:11 -0800
From: Doug Anderson <dianders@...omium.org>
To: Langyan Ye <yelangyan@...qin.corp-partner.google.com>
Cc: neil.armstrong@...aro.org, quic_jesszhan@...cinc.com, 
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de, 
	airlied@...il.com, simona@...ll.ch, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/panel-edp: Add support for 2 panels

Hi,

On Fri, Dec 20, 2024 at 4:21 AM Langyan Ye
<yelangyan@...qin.corp-partner.google.com> wrote:
>
> Add support for the following 2 panels:
> 1. B140UAN04.4
> 2. CXOT T9

Can you please include the panel names in the subject line instead of
just "add 2 panels"? Otherwise all the changes to this file look like
the same subject. AKA, like:

drm/panel-edp: Add B140UAN04.4 and CXOT T9


> The raw edid for B140UAN04.4 panel is:
>
> 00 ff ff ff ff ff ff 00 06 af b3 a7 00 00 00 00
> 0c 22 01 04 a5 1e 13 78 03 cb 55 91 57 5a 91 29
> 1c 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 f4 3c 80 b8 70 b0 24 40 10 10
> 3e 00 2d bc 10 00 00 18 00 00 00 0f 00 00 00 00
> 00 00 00 00 00 00 00 00 00 20 00 00 00 fe 00 41
> 55 4f 0a 20 20 20 20 20 20 20 20 20 00 00 00 fe
> 00 42 31 34 30 55 41 4e 30 34 2e 34 20 0a 01 46
>
> 70 20 79 02 00 22 00 14 87 61 02 85 7f 07 b7 00
> 0f 80 0f 00 af 04 23 00 02 00 0d 00 25 01 09 87
> 61 02 87 61 02 28 3c 80 81 00 15 74 1a 00 00 03
> 01 28 3c 00 00 53 50 53 50 3c 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0b 90
>
> The raw edid for CXOT T9 panel is:
>
> 00 ff ff ff ff ff ff 00 0e 77 48 14 00 00 00 00
> 34 20 01 04 a5 1e 13 78 03 2c c5 94 5c 59 95 29
> 1e 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 ea 3d 80 c8 70 b0 2e 40 30 20
> 36 00 2e bd 10 00 00 1a 00 00 00 fd 00 28 3c 4b
> 4b 10 01 0a 20 20 20 20 20 20 00 00 00 fe 00 43
> 53 4f 54 20 54 39 0a 20 20 20 20 20 00 00 00 fe
> 00 4d 4e 45 30 30 37 51 53 33 2d 37 0a 20 00 df

Thanks for including the EDIDs!


> Signed-off-by: Langyan Ye <yelangyan@...qin.corp-partner.google.com>
> ---
>  drivers/gpu/drm/panel/panel-edp.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> index f8511fe5fb0d..f41a9077c633 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -1865,6 +1865,7 @@ static const struct edp_panel_entry edp_panels[] = {
>         EDP_PANEL_ENTRY('A', 'U', 'O', 0xc4b4, &delay_200_500_e50, "B116XAT04.1"),
>         EDP_PANEL_ENTRY('A', 'U', 'O', 0xd497, &delay_200_500_e50, "B120XAN01.0"),
>         EDP_PANEL_ENTRY('A', 'U', 'O', 0xf390, &delay_200_500_e50, "B140XTN07.7"),
> +       EDP_PANEL_ENTRY('A', 'U', 'O', 0xa7b3, &delay_200_500_e50, "B140UAN04.4"),

This is not sorted properly. 0xa7b3 does not come later than 0xf390.


> @@ -1954,6 +1955,7 @@ static const struct edp_panel_entry edp_panels[] = {
>
>         EDP_PANEL_ENTRY('C', 'S', 'W', 0x1100, &delay_200_500_e80_d50, "MNB601LS1-1"),
>         EDP_PANEL_ENTRY('C', 'S', 'W', 0x1104, &delay_200_500_e50, "MNB601LS1-4"),
> +       EDP_PANEL_ENTRY('C', 'S', 'W', 0x1448, &delay_200_500_e50, "CXOT T9"),

>From the EDID, I notice that this reports as `MNE007QS3-7`, not `T9`.
I also wonder if CXOT is a misspelling of `CSOT` which appears to be
the manufacturer specified by "CSW"
(https://uefi.org/PNP_ID_List?pnp_search=csw). If so, I don't think
you need it.


Normally for simple things I'll just fix them up and apply, but I
don't know enough about the "CXOT T9" string to fix it myself so
you'll need to send a V2. Note that I will be away from my email for
the next 2 weeks so I probably won't get to apply it until sometime in
January unless you send a V2 in the next few hours...

-Doug