linux-kernel - Re: [PATCH 09/14] tracing/string: Create and use __free(argv_free) in trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20241220102814.13e12e4c@gandalf.local.home>
Date: Fri, 20 Dec 2024 10:28:14 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-trace-kernel@...r.kernel.org" <linux-trace-kernel@...r.kernel.org>,
 Masami Hiramatsu <mhiramat@...nel.org>, Mark Rutland
 <mark.rutland@....com>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Andrew Morton <akpm@...ux-foundation.org>, Peter Zijlstra
 <peterz@...radead.org>, Kees Cook <kees@...nel.org>, Andy Shevchenko
 <andy@...nel.org>, "linux-hardening@...r.kernel.org"
 <linux-hardening@...r.kernel.org>
Subject: Re: [PATCH 09/14] tracing/string: Create and use __free(argv_free)
 in trace_dynevent.c

On Fri, 20 Dec 2024 15:48:44 +0200
Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> пʼятниця, 20 грудня 2024 р. Steven Rostedt <rostedt@...dmis.org> пише:
> 
> > On Fri, 20 Dec 2024 08:56:44 +0200
> > Andy Shevchenko <andy.shevchenko@...il.com> wrote:
> >  
> > > > diff --git a/include/linux/string.h b/include/linux/string.h
> > > > index 493ac4862c77..c995f973a59a 100644
> > > > --- a/include/linux/string.h
> > > > +++ b/include/linux/string.h
> > > > @@ -10,6 +10,7 @@
> > > >  #include <linux/err.h>         /* for ERR_PTR() */
> > > >  #include <linux/errno.h>       /* for E2BIG */
> > > >  #include <linux/overflow.h>    /* for check_mul_overflow() */
> > > > +#include <linux/cleanup.h>     /* for DEFINE_FREE() */  
> > >
> > >
> > >
> > > Can you keep it ordered?  
> >
> > Not sure what order you want to keep?
> >  
> > >
> > >  
> > > >  #include <linux/stdarg.h>
> > > >  #include <uapi/linux/string.h>
> > > >  
> >
> >
> > #include <linux/args.h>
> > #include <linux/array_size.h>  
> 
> 
> 
> If you put it here it would make more like alphabetical order with only few
> exceptions

Sure, I'll send out a v2. Thanks for the review.

--Steve

> 
> #include <linux/compiler.h>     /* for inline */
> > #include <linux/types.h>        /* for size_t */
> > #include <linux/stddef.h>       /* for NULL */
> > #include <linux/err.h>          /* for ERR_PTR() */
> > #include <linux/errno.h>        /* for E2BIG */
> > #include <linux/overflow.h>     /* for check_mul_overflow() */
> > #include <linux/cleanup.h>      /* for DEFINE_FREE() */
> > #include <linux/stdarg.h>
> > #include <uapi/linux/string.h>
> >
> > It's not alphabetical, nor in x-mas tree order. I was never good at these
> > "find the pattern" puzzles ;-)
> >
> > -- Steve
> >