linux-kernel - Re: [PATCH] nvmem: qcom-spmi-sdam: Set size in struct nvmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9030fb2-85a1-4b13-8fac-94ee2defca14@linaro.org>
Date: Fri, 20 Dec 2024 18:36:54 +0200
From: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>
To: Luca Weiss <luca.weiss@...rphone.com>,
 Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Shyam Kumar Thella <sthella@...eaurora.org>,
 Anirudh Ghayal <quic_aghayal@...cinc.com>,
 Guru Das Srinagesh <quic_gurus@...cinc.com>
Cc: ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH] nvmem: qcom-spmi-sdam: Set size in struct nvmem_config

On 12/20/24 14:22, Luca Weiss wrote:
> Let the nvmem core know what size the SDAM is, most notably this fixes
> the size of /sys/bus/nvmem/devices/spmi_sdam*/nvmem being '0' and makes
> user space work with that file.
> 
>    ~ # hexdump -C -s 64 /sys/bus/nvmem/devices/spmi_sdam2/nvmem
>    00000040  02 01 00 00 04 00 00 00  00 00 00 00 00 00 00 00  |................|
>    00000050  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
>    *
>    00000080
> 
> Fixes: 40ce9798794f ("nvmem: add QTI SDAM driver")
> Cc: stable@...r.kernel.org
> Signed-off-by: Luca Weiss <luca.weiss@...rphone.com>

Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>

> ---
> Related, it would be nice to set sdam->sdam_config.type to an
> appropriate value, the ones currently upstream are:
> 
>    enum nvmem_type {
>        NVMEM_TYPE_UNKNOWN = 0,
>        NVMEM_TYPE_EEPROM,
>        NVMEM_TYPE_OTP,
>        NVMEM_TYPE_BATTERY_BACKED,
>        NVMEM_TYPE_FRAM,
>    };
> 
> I don't know what would fit for SDAM and I couldn't find any info on
> createpoint either, not even what the abbreviation SDAM stands for.
> ---
>   drivers/nvmem/qcom-spmi-sdam.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/nvmem/qcom-spmi-sdam.c b/drivers/nvmem/qcom-spmi-sdam.c
> index 9aa8f42faa4c93532cf8c70ea992a4fbb005d006..4f1cca6eab71e1efc5328448f69f863e6db57c5a 100644
> --- a/drivers/nvmem/qcom-spmi-sdam.c
> +++ b/drivers/nvmem/qcom-spmi-sdam.c
> @@ -144,6 +144,7 @@ static int sdam_probe(struct platform_device *pdev)
>   	sdam->sdam_config.owner = THIS_MODULE;
>   	sdam->sdam_config.add_legacy_fixed_of_cells = true;
>   	sdam->sdam_config.stride = 1;
> +	sdam->sdam_config.size = sdam->size;
>   	sdam->sdam_config.word_size = 1;
>   	sdam->sdam_config.reg_read = sdam_read;
>   	sdam->sdam_config.reg_write = sdam_write;
> 

--
Best wishes,
Vladimir