linux-kernel - Re: [PATCH] staging: gpib: cb7210: Add error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ae31f6f4-c94d-49f8-a327-fafc018b246c@gmail.com>
Date: Sat, 21 Dec 2024 14:06:31 +0530
From: Nihar Chaithanya <niharchaithanya@...il.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: dpenkler@...il.com, dan.carpenter@...aro.org, roheetchavan@...il.com,
 arnd@...db.de, linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
 skhan@...uxfoundation.org
Subject: Re: [PATCH] staging: gpib: cb7210: Add error handling


On 21/12/24 13:21, Greg KH wrote:
> On Sat, Dec 21, 2024 at 07:56:33AM +0530, Nihar Chaithanya wrote:
>> The if condition in cb7210_init_module() would always fail as
>> the value of err is constantly 0.
>> Add error handling to cb_pcmcia_init_module() where it returns
>> appropriate error code if pcmcia_register_driver() fails.
>>
>> This issue was reported by Coverity Scan.
>> Report:
>>
>> CID 1635894: (#1 of 1): 'Constant' variable guards dead code (DEADCODE)
>> dead_error_line: Execution cannot reach this statement: return -1;.
>>
>> Signed-off-by: Nihar Chaithanya <niharchaithanya@...il.com>
>> ---
>>   drivers/staging/gpib/cb7210/cb7210.c | 11 ++++++++---
>>   1 file changed, 8 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/gpib/cb7210/cb7210.c b/drivers/staging/gpib/cb7210/cb7210.c
>> index 63df7f3eb3f3..b2f6ad70ccaf 100644
>> --- a/drivers/staging/gpib/cb7210/cb7210.c
>> +++ b/drivers/staging/gpib/cb7210/cb7210.c
>> @@ -1353,7 +1353,11 @@ static struct pcmcia_driver cb_gpib_cs_driver = {
>>   
>>   int cb_pcmcia_init_module(void)
>>   {
>> -	pcmcia_register_driver(&cb_gpib_cs_driver);
>> +	int ret;
>> +
>> +	ret = pcmcia_register_driver(&cb_gpib_cs_driver);
>> +	if (ret < 0)
>> +		return ret;
>>   	return 0;
> Why not make this whole function just one line?  And then, as it's one
> line, why is it a function at all?
>
> thanks,
>
> greg k-h
Hi Greg, yes, this redundant cb_pcmcia_init_module() can be replaced with
pcmcia_register_driver() where it's being called. I'll send the version 2
making these changes.

Thank you,
Nihar