linux-kernel - Re: [PATCH] ARM: dts: ti: am437x-l4: remove autoidle for UART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z2ajiuumq0CeM/u7@dev-linux>
Date: Sat, 21 Dec 2024 03:16:26 -0800
From: Sukrut Bellary <sbellary@...libre.com>
To: Judith Mendez <jm@...com>
Cc: Tony Lindgren <tony@...mide.com>, Kevin Hilman <khilman@...com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-omap@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Bin Liu <b-liu@...com>
Subject: Re: [PATCH] ARM: dts: ti: am437x-l4: remove autoidle for UART

On Fri, Dec 20, 2024 at 04:35:23PM -0600, Judith Mendez wrote:
> According to the TRM [0] in 21.5.1.42 UART_SYSC Register,
> the autoidle bit should not be set for UART, so remove the
> appropriate SYSC_OMAP2_AUTOIDLE flag.
> 
> [0] https://www.ti.com/lit/ug/spruhl7i/spruhl7i.pdf
> Signed-off-by: Judith Mendez <jm@...com>
> ---
>  arch/arm/boot/dts/ti/omap/am437x-l4.dtsi | 18 ++++++------------
>  1 file changed, 6 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi b/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi
> index 824b9415ebbe9..fd4634f8c6293 100644
> --- a/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi
> @@ -180,8 +180,7 @@ target-module@...0 {			/* 0x44e09000, ap 16 04.0 */
>  			      <0x9058 0x4>;
>  			reg-names = "rev", "sysc", "syss";
>  			ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP |
> -					 SYSC_OMAP2_SOFTRESET |
> -					 SYSC_OMAP2_AUTOIDLE)>;
> +					 SYSC_OMAP2_SOFTRESET)>;
>  			ti,sysc-sidle = <SYSC_IDLE_FORCE>,
>  					<SYSC_IDLE_NO>,
>  					<SYSC_IDLE_SMART>,
> @@ -698,8 +697,7 @@ target-module@...00 {			/* 0x48022000, ap 8 0a.0 */
>  			      <0x22058 0x4>;
>  			reg-names = "rev", "sysc", "syss";
>  			ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP |
> -					 SYSC_OMAP2_SOFTRESET |
> -					 SYSC_OMAP2_AUTOIDLE)>;
> +					 SYSC_OMAP2_SOFTRESET)>;
>  			ti,sysc-sidle = <SYSC_IDLE_FORCE>,
>  					<SYSC_IDLE_NO>,
>  					<SYSC_IDLE_SMART>,
> @@ -726,8 +724,7 @@ target-module@...00 {			/* 0x48024000, ap 10 1c.0 */
>  			      <0x24058 0x4>;
>  			reg-names = "rev", "sysc", "syss";
>  			ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP |
> -					 SYSC_OMAP2_SOFTRESET |
> -					 SYSC_OMAP2_AUTOIDLE)>;
> +					 SYSC_OMAP2_SOFTRESET)>;
>  			ti,sysc-sidle = <SYSC_IDLE_FORCE>,
>  					<SYSC_IDLE_NO>,
>  					<SYSC_IDLE_SMART>,
> @@ -1385,8 +1382,7 @@ target-module@...00 {			/* 0x481a6000, ap 40 16.0 */
>  			      <0xa6058 0x4>;
>  			reg-names = "rev", "sysc", "syss";
>  			ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP |
> -					 SYSC_OMAP2_SOFTRESET |
> -					 SYSC_OMAP2_AUTOIDLE)>;
> +					 SYSC_OMAP2_SOFTRESET)>;
>  			ti,sysc-sidle = <SYSC_IDLE_FORCE>,
>  					<SYSC_IDLE_NO>,
>  					<SYSC_IDLE_SMART>,
> @@ -1413,8 +1409,7 @@ target-module@...00 {			/* 0x481a8000, ap 42 20.0 */
>  			      <0xa8058 0x4>;
>  			reg-names = "rev", "sysc", "syss";
>  			ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP |
> -					 SYSC_OMAP2_SOFTRESET |
> -					 SYSC_OMAP2_AUTOIDLE)>;
> +					 SYSC_OMAP2_SOFTRESET)>;
>  			ti,sysc-sidle = <SYSC_IDLE_FORCE>,
>  					<SYSC_IDLE_NO>,
>  					<SYSC_IDLE_SMART>,
> @@ -1441,8 +1436,7 @@ target-module@...00 {			/* 0x481aa000, ap 44 12.0 */
>  			      <0xaa058 0x4>;
>  			reg-names = "rev", "sysc", "syss";
>  			ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP |
> -					 SYSC_OMAP2_SOFTRESET |
> -					 SYSC_OMAP2_AUTOIDLE)>;
> +					 SYSC_OMAP2_SOFTRESET)>;
>  			ti,sysc-sidle = <SYSC_IDLE_FORCE>,
>  					<SYSC_IDLE_NO>,
>  					<SYSC_IDLE_SMART>,
> -- 
> 2.47.1
>

Looks good to me.

Reviewed-by: Sukrut Bellary <sbellary@...libre.com>