linux-kernel - Re: [PATCH v11 11/22] crypto: amlogic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z2aokzSrAHpJE_PG@gondor.apana.org.au>
Date: Sat, 21 Dec 2024 19:37:55 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Alexey Romanov <avromanov@...utedevices.com>
Cc: neil.armstrong@...aro.org, clabbe@...libre.com, davem@...emloft.net,
	robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, khilman@...libre.com,
	jbrunet@...libre.com, martin.blumenstingl@...glemail.com,
	vadim.fedorenko@...ux.dev, linux-crypto@...r.kernel.org,
	linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	kernel@...utedevices.com
Subject: Re: [PATCH v11 11/22] crypto: amlogic - Introduce hasher

On Fri, Dec 13, 2024 at 05:07:44PM +0300, Alexey Romanov wrote:
>
> +static int meson_sha_digest(struct ahash_request *req)
> +{
> +	struct crypto_wait wait;
> +	int ret;
> +
> +	crypto_init_wait(&wait);
> +	ahash_request_set_callback(req, CRYPTO_TFM_REQ_MAY_SLEEP |
> +					CRYPTO_TFM_REQ_MAY_BACKLOG,
> +					crypto_req_done, &wait);
> +
> +	meson_sha_init(req);
> +
> +	ret = crypto_wait_req(meson_sha_update(req), &wait);

You cannot sleep in the digest function.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt