[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20241221141009.27317-1-18255117159@163.com>
Date: Sat, 21 Dec 2024 22:10:09 +0800
From: Hans Zhang <18255117159@....com>
To: manivannan.sadhasivam@...aro.org
Cc: kw@...ux.com,
kishon@...nel.org,
arnd@...db.de,
gregkh@...uxfoundation.org,
linux-pci@...r.kernel.org,
linux-kernel@...r.kernel.org,
rockswang7@...il.com,
Hans Zhang <18255117159@....com>,
Niklas Cassel <cassel@...nel.org>
Subject: [v3] misc: pci_endpoint_test: Fix return resource_size_t from pci_resource_len
With 8GB BAR2, running pcitest -b 2 fails with "TEST FAILED".
The return value of the `pci_resource_len` interface is not an integer.
Using `pcitest` with an 8GB BAR2, the bar_size of integer type will
overflow.
Change the data type of bar_size from integer to resource_size_t, to fix
the above issue.
Signed-off-by: Hans Zhang <18255117159@....com>
Reviewed-by: Niklas Cassel <cassel@...nel.org>
---
Changes since v2:
https://lore.kernel.org/linux-pci/20241220075253.16791-1-18255117159@163.com/
- Fix "changes" part goes below the --- line
- The patch commit message were modified.
Changes since v1:
https://lore.kernel.org/linux-pci/20241217121220.19676-1-18255117159@163.com/
- The patch subject and commit message were modified.
---
drivers/misc/pci_endpoint_test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
index 3aaaf47fa4ee..414c4e55fb0a 100644
--- a/drivers/misc/pci_endpoint_test.c
+++ b/drivers/misc/pci_endpoint_test.c
@@ -280,10 +280,11 @@ static int pci_endpoint_test_bar_memcmp(struct pci_endpoint_test *test,
static bool pci_endpoint_test_bar(struct pci_endpoint_test *test,
enum pci_barno barno)
{
- int j, bar_size, buf_size, iters, remain;
void *write_buf __free(kfree) = NULL;
void *read_buf __free(kfree) = NULL;
struct pci_dev *pdev = test->pdev;
+ int j, buf_size, iters, remain;
+ resource_size_t bar_size;
if (!test->bar[barno])
return false;
--
2.25.1
Powered by blists - more mailing lists