linux-kernel - Re: [PATCH] mm: remove unnecessary calls to lru_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <938c59d4-9ad4-4fdb-bd3d-0de139a940c3@redhat.com>
Date: Sat, 21 Dec 2024 16:32:52 +0100
From: David Hildenbrand <david@...hat.com>
To: Shakeel Butt <shakeel.butt@...ux.dev>, Rik van Riel <riel@...riel.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Chris Li <chrisl@...nel.org>,
 Ryan Roberts <ryan.roberts@....com>,
 "Matthew Wilcox (Oracle)" <willy@...radead.org>, linux-mm@...ck.org,
 kernel-team@...a.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: remove unnecessary calls to lru_add_drain

> 
>>   	tlb_gather_mmu(&tlb, vms->vma->vm_mm);
>>   	update_hiwater_rss(vms->vma->vm_mm);
>>   	unmap_vmas(&tlb, mas_detach, vms->vma, vms->start, vms->end,
> 
> I hope this much history is good enough to convince Andrew. With that
> please add:
> 
> Acked-by: Shakeel Butt <shakeel.butt@...ux.dev>
> 

Yes, seems reasonable to me. Does it matter on small (32bit?) machines? 
Hard to judge, but being too careful here likely does not make sense 
until we learn that there is a real problem.

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb