[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <95a385a7-6a15-4dc8-b00d-d7fdb121aa67@kernel.org>
Date: Sat, 21 Dec 2024 21:07:29 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vincenzo Frascino <vincenzo.frascino@....com>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Sudeep Holla <sudeep.holla@....com>, Rob Herring <robh@...nel.org>
Subject: Re: [PATCH 8/8] MAINTAINERS: Add Vincenzo Frascino as Arm Morello
Maintainer
On 19/12/2024 18:45, Vincenzo Frascino wrote:
>
>
> On 14/12/2024 10:19, Krzysztof Kozlowski wrote:
>> On 13/12/2024 17:32, Vincenzo Frascino wrote:
>>> Cc: Sudeep Holla <sudeep.holla@....com>
>>> Cc: Rob Herring <robh@...nel.org>
>>> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@....com>
>>> ---
>>> MAINTAINERS | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index e6e71b05710b..8199e5945fb2 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -3304,6 +3304,12 @@ F: drivers/clocksource/timer-versatile.c
>>> X: drivers/cpufreq/vexpress-spc-cpufreq.c
>>> X: Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
>>>
>>> +ARM MORELLO PLATFORM SUPPORT
>>
>> Wrongly placed, M is not after V, I know people cannot keep order but
>> let's try. No need for new Boogaloo.
>>
>> Plus look how all the titles are created and do not come with different
>> style.
>>
>
> Not sure I understand what you mean here. Do you mean that I have to put Morello
> in alphabetical order in the file? Or just above VEXPRESS?
Entries in maintainers are ordered, keep the order.
>
> For what concerns the title, the MAINTAINERS file contains several styles (...
> PLATFORM, PLATFORM SUPPORT, etc). What's your preference?
Look how other arm platforms are called, e.g. vexpress. Create the same
style.
>>
>>
>> Missing bindings.
>>
>>
>
> There are no bindings specific to morello. What should I add here?
>
Ah, indeed, you added these to Vexpress Juno bindings. I missed that.
It's fine then.
Best regards,
Krzysztof
Powered by blists - more mailing lists