linux-kernel - Re: [PATCH] staging: gpib: Rename variable ValidAll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024122209-detract-unwitting-83ee@gregkh>
Date: Sun, 22 Dec 2024 10:35:34 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Dave Penkler <dpenkler@...il.com>
Cc: Antonio Riccio <linux@...ccio.me>, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: gpib: Rename variable ValidAll

On Sun, Dec 22, 2024 at 10:19:28AM +0100, Dave Penkler wrote:
> On Sun, Dec 22, 2024 at 07:11:40AM +0100, Greg Kroah-Hartman wrote:
> > On Sat, Dec 21, 2024 at 08:01:23PM +0000, Antonio Riccio wrote:
> > > --- a/drivers/staging/gpib/uapi/gpib_user.h
> > > +++ b/drivers/staging/gpib/uapi/gpib_user.h
> > > @@ -114,7 +114,7 @@ enum bus_control_line {
> > >  	ValidSRQ = 0x20,
> > >  	ValidATN = 0x40,
> > >  	ValidEOI = 0x80,
> > > -	ValidALL = 0xff,
> > > +	VALIDALL = 0xff,
> > 
> > Why are you only changing one of these?  And are you sure that these
> > values aren't coming from a specification with this type of naming?
> > 
> > thanks,
> > 
> > greg k-h
> I prefer that we keep the camel case definitions in the uapi includes
> as they are for now so that they remain compatible with the current
> user space includes. Over time I will release a version of the user
> space includes that provide compatability definitions for the
> checkpatch clean version of the uapi includes. This includes the camel
> case definitions and the typedefs. I will submit a patches for this in
> the new year.

Ah, this is uapi, we really can't change them all that easily anyway :)

thanks for the quick review.

greg k-h