linux-kernel - Re: [PATCH] crypto: lib/gf128mul

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z2f-CXgNGkstB4ds@gallifrey>
Date: Sun, 22 Dec 2024 11:54:49 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: Herbert Xu <herbert@...dor.apana.org.au>
Cc: davem@...emloft.net, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: lib/gf128mul - Remove some bbe deadcode

* Herbert Xu (herbert@...dor.apana.org.au) wrote:
> On Wed, Dec 11, 2024 at 10:02:18PM +0000, linux@...blig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@...blig.org>
> > 
> > gf128mul_4k_bbe(), gf128mul_bbe() and gf128mul_init_4k_bbe()
> > are part of the library originally added in 2006 by
> > commit c494e0705d67 ("[CRYPTO] lib: table driven multiplications in
> > GF(2^128)")
> > 
> > but have never been used.
> > 
> > Remove them.
> > (BBE is Big endian Byte/Big endian bits
> > Note the 64k table version is used and I've left that in)
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> > ---
> >  include/crypto/gf128mul.h |  6 +---
> >  lib/crypto/gf128mul.c     | 75 ---------------------------------------
> >  2 files changed, 1 insertion(+), 80 deletions(-)
> 
> Patch applied.  Thanks.

Thanks!  I'd appreciate if you could also look back at one
from September:
  async_xor: Remove unused 'async_xor_val'
  Message ID: 20240929132148.44792-1-linux@...blig.org

Thanks again,

Dave

> -- 
> Email: Herbert Xu <herbert@...dor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/