[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d1c6d2f2-f733-4cbe-8108-c9c9aaa417cc@kernel.org>
Date: Sun, 22 Dec 2024 15:46:53 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Markuss Broks <markuss.broks@...il.com>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Lorenzo Pieralisi <lpieralisi@...nel.org>,
Alim Akhtar <alim.akhtar@...sung.com>,
Sylwester Nawrocki <s.nawrocki@...sung.com>,
Linus Walleij <linus.walleij@...aro.org>, Tomasz Figa
<tomasz.figa@...il.com>, Will Deacon <will@...nel.org>,
Mark Rutland <mark.rutland@....com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
linux-gpio@...r.kernel.org, Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>,
Maksym Holovach <nergzd@...gzd723.xyz>
Subject: Re: [PATCH RESEND v4 1/2] arm64: dts: exynos: Add Exynos9810 SoC
support
On 14/12/2024 15:56, Markuss Broks wrote:
> + pinctrl0 = &pinctrl_alive;
> + pinctrl1 = &pinctrl_aud;
> + pinctrl2 = &pinctrl_chub;
> + pinctrl3 = &pinctrl_cmgp;
> + pinctrl4 = &pinctrl_fsys0;
> + pinctrl5 = &pinctrl_fsys1;
> + pinctrl6 = &pinctrl_peric0;
> + pinctrl7 = &pinctrl_peric1;
> + pinctrl8 = &pinctrl_vts;
> + };
> +
> + arm-a55-pmu {
> + compatible = "arm,cortex-a55-pmu";
> + interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-affinity = <&cpu0>,
> + <&cpu1>,
> + <&cpu2>,
> + <&cpu3>;
> + };
> +
> + mongoose-m3-pmu {
So the name chosen by previous people some time ago for arm PMU is
obviously not the best - forces either messed sorting or having PMU
nodes in different places. That's why people should almost always go
with prefix, no suffix. See regulators and clocks.
Fixed and applied.
Best regards,
Krzysztof
Powered by blists - more mailing lists