linux-kernel - Re: [PATCH] Input: atkbd: Fix so copilot key generates F23 keycode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <65fbce93-5f73-4b09-af55-c5d782691773@app.fastmail.com>
Date: Sun, 22 Dec 2024 15:16:49 -0500
From: "Mark Pearson" <mpearson-lenovo@...ebb.ca>
To: "Dmitry Torokhov" <dmitry.torokhov@...il.com>
Cc: "Hans de Goede" <hdegoede@...hat.com>,
 "Peter Hutterer" <peter.hutterer@...hat.com>, linux-input@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: atkbd: Fix so copilot key generates F23 keycode

Hi Dmitry,

On Thu, Dec 19, 2024, at 2:17 PM, Dmitry Torokhov wrote:
> On Thu, Dec 19, 2024 at 01:40:24PM -0500, Mark Pearson wrote:
>> On Thu, Dec 19, 2024, at 1:31 PM, Dmitry Torokhov wrote:
>> > On Thu, Dec 19, 2024 at 07:26:19PM +0100, Hans de Goede wrote:
>> >> Hi,
>> >> 
>> >> On 19-Dec-24 7:15 PM, Dmitry Torokhov wrote:
>> > And mapping to F23 as I said should be done through udev. I doubt they
>> > will get all OEMs settle on the same scancode.
>> >
>> 
>> I'll see if we can find a way to check on other vendor platforms what scancode is used.
>> If it is a common scancode, across multiple vendors, would the patch be acceptable?
>
> It is currently unmapped by default, so maybe.
>
> FWIW:
>
> dtor@...r-ws:~/kernel/work $ grep KEY_6e /lib/udev/hwdb.d/60-keyboard.hwdb
> KEYBOARD_KEY_6e=wlan
> KEYBOARD_KEY_6e=left                                   # left on d-pad
> KEYBOARD_KEY_6e=search
>
> That 2nd entry is actually from one of Thinkpad models ;)
>
I got confirmation from the keyboard team that 0x6e is the scancode from F23, and is common for all PC vendors for Windows.

They pointed me at this page as confirmation: https://learn.microsoft.com/en-us/windows/win32/inputdev/about-keyboard-input#scan-codes
(F23 is in the table of scan codes)

Does that make this patch valid again for consideration, in your opinion?

Thanks
Mark