linux-kernel - Re: [PATCH 2/2] alienware-wmi: Use devm_platform_profile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3924cdc3-0833-4cde-8473-6cde8513fe27@gmx.de>
Date: Sun, 22 Dec 2024 23:12:41 +0100
From: Armin Wolf <W_Armin@....de>
To: Kurt Borja <kuurtb@...il.com>, platform-driver-x86@...r.kernel.org
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Mark Pearson <mpearson-lenovo@...ebb.ca>,
 Mario Limonciello <mario.limonciello@....com>,
 Hans de Goede <hdegoede@...hat.com>, Gergo Koteles <soyer@....hu>,
 linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] alienware-wmi: Use devm_platform_profile_register()

Am 21.12.24 um 08:08 schrieb Kurt Borja:

> Replace platform_profile_register() with it's device managed version.
> Drop remove_thermal_profile() because it's no longer needed.

Reviewed-by: Armin Wolf <W_Armin@....de>

> Signed-off-by: Kurt Borja <kuurtb@...il.com>
> ---
>   drivers/platform/x86/dell/alienware-wmi.c | 10 +---------
>   1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/platform/x86/dell/alienware-wmi.c b/drivers/platform/x86/dell/alienware-wmi.c
> index e95d22c7b60c..7b3ee2d6a23d 100644
> --- a/drivers/platform/x86/dell/alienware-wmi.c
> +++ b/drivers/platform/x86/dell/alienware-wmi.c
> @@ -1159,13 +1159,7 @@ static int create_thermal_profile(struct platform_device *platform_device)
>   	pp_handler.name = "alienware-wmi";
>   	pp_handler.dev = &platform_device->dev;
>
> -	return platform_profile_register(&pp_handler);
> -}
> -
> -static void remove_thermal_profile(void)
> -{
> -	if (quirks->thermal)
> -		platform_profile_remove(&pp_handler);
> +	return devm_platform_profile_register(&pp_handler);
>   }
>
>   static int __init alienware_wmi_init(void)
> @@ -1239,7 +1233,6 @@ static int __init alienware_wmi_init(void)
>
>   fail_prep_zones:
>   	alienware_zone_exit(platform_device);
> -	remove_thermal_profile();
>   fail_prep_thermal_profile:
>   fail_prep_deepsleep:
>   fail_prep_amplifier:
> @@ -1260,7 +1253,6 @@ static void __exit alienware_wmi_exit(void)
>   	if (platform_device) {
>   		alienware_zone_exit(platform_device);
>   		remove_hdmi(platform_device);
> -		remove_thermal_profile();
>   		platform_device_unregister(platform_device);
>   		platform_driver_unregister(&platform_driver);
>   	}