linux-kernel - Re: drivers/crypto/tegra/tegra-se-aes.c:1596 tegra_cmac_do_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z2eS-r-HGWIR9gNj@gondor.apana.org.au>
Date: Sun, 22 Dec 2024 12:18:02 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: oe-kbuild@...ts.linux.dev, Akhil R <akhilrajeev@...dia.com>,
	lkp@...el.com, oe-kbuild-all@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: drivers/crypto/tegra/tegra-se-aes.c:1596 tegra_cmac_do_one_req()
 error: uninitialized symbol 'ret'.

On Mon, Dec 09, 2024 at 09:24:49AM +0300, Dan Carpenter wrote:
>
> vim +/ret +1596 drivers/crypto/tegra/tegra-se-aes.c
> 
> 0880bb3b00c855f Akhil R 2024-04-03  1577  static int tegra_cmac_do_one_req(struct crypto_engine *engine, void *areq)
> 0880bb3b00c855f Akhil R 2024-04-03  1578  {
> 0880bb3b00c855f Akhil R 2024-04-03  1579  	struct ahash_request *req = ahash_request_cast(areq);
> 0880bb3b00c855f Akhil R 2024-04-03  1580  	struct tegra_cmac_reqctx *rctx = ahash_request_ctx(req);
> 0880bb3b00c855f Akhil R 2024-04-03  1581  	struct crypto_ahash *tfm = crypto_ahash_reqtfm(req);
> 0880bb3b00c855f Akhil R 2024-04-03  1582  	struct tegra_cmac_ctx *ctx = crypto_ahash_ctx(tfm);
> 0880bb3b00c855f Akhil R 2024-04-03  1583  	struct tegra_se *se = ctx->se;
> 0880bb3b00c855f Akhil R 2024-04-03  1584  	int ret;
> 0880bb3b00c855f Akhil R 2024-04-03  1585  
> 0880bb3b00c855f Akhil R 2024-04-03  1586  	if (rctx->task & SHA_UPDATE) {
> 0880bb3b00c855f Akhil R 2024-04-03  1587  		ret = tegra_cmac_do_update(req);
> 0880bb3b00c855f Akhil R 2024-04-03  1588  		rctx->task &= ~SHA_UPDATE;
> 0880bb3b00c855f Akhil R 2024-04-03  1589  	}
> 0880bb3b00c855f Akhil R 2024-04-03  1590  
> 0880bb3b00c855f Akhil R 2024-04-03  1591  	if (rctx->task & SHA_FINAL) {
> 0880bb3b00c855f Akhil R 2024-04-03  1592  		ret = tegra_cmac_do_final(req);
> 0880bb3b00c855f Akhil R 2024-04-03  1593  		rctx->task &= ~SHA_FINAL;
> 0880bb3b00c855f Akhil R 2024-04-03  1594  	}
> 
> Is it possible for both SHA_UPDATE and SHA_FINAL to be clear?

I don't think so.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt