linux-kernel - Re: [PATCH] staging: gpib: Rename variable ValidAll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024122201-uncivil-footnote-f584@gregkh>
Date: Sun, 22 Dec 2024 07:11:40 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Antonio Riccio <linux@...ccio.me>
Cc: Dave Penkler <dpenkler@...il.com>, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: gpib: Rename variable ValidAll

On Sat, Dec 21, 2024 at 08:01:23PM +0000, Antonio Riccio wrote:
> --- a/drivers/staging/gpib/uapi/gpib_user.h
> +++ b/drivers/staging/gpib/uapi/gpib_user.h
> @@ -114,7 +114,7 @@ enum bus_control_line {
>  	ValidSRQ = 0x20,
>  	ValidATN = 0x40,
>  	ValidEOI = 0x80,
> -	ValidALL = 0xff,
> +	VALIDALL = 0xff,

Why are you only changing one of these?  And are you sure that these
values aren't coming from a specification with this type of naming?

thanks,

greg k-h