linux-kernel - Re: [PATCH v3] staging: gpib: Add error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202412221424.WIjKFIPf-lkp@intel.com>
Date: Sun, 22 Dec 2024 15:06:22 +0800
From: kernel test robot <lkp@...el.com>
To: Nihar Chaithanya <niharchaithanya@...il.com>, dpenkler@...il.com,
	gregkh@...uxfoundation.org, roheetchavan@...il.com, arnd@...db.de,
	dan.carpenter@...aro.org, kees@...erbout.nl,
	m.omerfarukbulut@...il.com, skhan@...uxfoundation.org,
	everestkc@...restkc.com.np, dominik.karol.piatkowski@...tonmail.com,
	nathan@...nel.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH v3] staging: gpib: Add error handling

Hi Nihar,

kernel test robot noticed the following build errors:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/intel-lab-lkp/linux/commits/Nihar-Chaithanya/staging-gpib-Add-error-handling/20241222-060646
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/20241221214822.163667-1-niharchaithanya%40gmail.com
patch subject: [PATCH v3] staging: gpib: Add error handling
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20241222/202412221424.WIjKFIPf-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241222/202412221424.WIjKFIPf-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412221424.WIjKFIPf-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/staging/gpib/fmh_gpib/fmh_gpib.c: In function 'fmh_gpib_init_module':
>> drivers/staging/gpib/fmh_gpib/fmh_gpib.c:1694:17: error: label 'err_platform_driver' used but not defined
    1694 |                 goto err_platform_driver;
         |                 ^~~~


vim +/err_platform_driver +1694 drivers/staging/gpib/fmh_gpib/fmh_gpib.c

  1687	
  1688	static int __init fmh_gpib_init_module(void)
  1689	{
  1690		int result;
  1691	
  1692		result = platform_driver_register(&fmh_gpib_platform_driver);
  1693		if (result)
> 1694			goto err_platform_driver;
  1695	
  1696		result = pci_register_driver(&fmh_gpib_pci_driver);
  1697		if (result)
  1698			goto err_pci_driver;
  1699	
  1700		result = gpib_register_driver(&fmh_gpib_unaccel_interface, THIS_MODULE);
  1701		if (result)
  1702			goto err_unaccel;
  1703	
  1704		result = gpib_register_driver(&fmh_gpib_interface, THIS_MODULE);
  1705		if (result)
  1706			goto err_interface;
  1707	
  1708		result = gpib_register_driver(&fmh_gpib_pci_unaccel_interface, THIS_MODULE);
  1709		if (result)
  1710			goto err_pci_unaccel;
  1711	
  1712		result = gpib_register_driver(&fmh_gpib_pci_interface, THIS_MODULE);
  1713		if (result)
  1714			goto err_pci;
  1715	
  1716		return 0;
  1717	
  1718	err_pci:
  1719		gpib_unregister_driver(&fmh_gpib_pci_unaccel_interface);
  1720	err_pci_unaccel:
  1721		gpib_unregister_driver(&fmh_gpib_interface);
  1722	err_interface:
  1723		gpib_unregister_driver(&fmh_gpib_unaccel_interface);
  1724	err_unaccel:
  1725		pci_unregister_driver(&fmh_gpib_pci_driver);
  1726	err_pci_driver:
  1727		platform_driver_unregister(&fmh_gpib_platform_driver);
  1728	
  1729		return result;
  1730	}
  1731	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki