linux-kernel - Re: [RESEND PATCH] alpha: Replace one-element array with flexible array member

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202412222144.61622A2@keescook>
Date: Sun, 22 Dec 2024 21:46:17 -0800
From: Kees Cook <kees@...nel.org>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Richard Henderson <richard.henderson@...aro.org>,
	Matt Turner <mattst88@...il.com>, linux-hardening@...r.kernel.org,
	linux-alpha@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] alpha: Replace one-element array with flexible
 array member

On Fri, Dec 20, 2024 at 08:20:20PM +0100, Thorsten Blum wrote:
> Replace the deprecated one-element array with a modern flexible array
> member in the struct crb_struct.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>  arch/alpha/include/asm/hwrpb.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/alpha/include/asm/hwrpb.h b/arch/alpha/include/asm/hwrpb.h
> index fc76f36265ad..db831cf8de10 100644
> --- a/arch/alpha/include/asm/hwrpb.h
> +++ b/arch/alpha/include/asm/hwrpb.h
> @@ -135,7 +135,7 @@ struct crb_struct {
>  	/* virtual->physical map */
>  	unsigned long map_entries;
>  	unsigned long map_pages;
> -	struct vf_map_struct map[1];
> +	struct vf_map_struct map[];
>  };

Seems like this could use __counted_by(map_entries) as well?

...
                for (i = 0; i < crb->map_entries; ++i) {
                        unsigned long pfn = crb->map[i].pa >> PAGE_SHIFT;
...

But yes, this appears to be used as a flexible array and should be
adjusted. I see no sizeof() uses that would change. So:

Reviewed-by: Kees Cook <kees@...nel.org>

-Kees

-- 
Kees Cook