linux-kernel - Re: [PATCH RESEND] soundwire: amd: clear wake enable register for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c7565ec5-96dd-486e-929e-2d22d9e0282a@amd.com>
Date: Mon, 23 Dec 2024 11:43:17 +0530
From: "Mukunda,Vijendar" <vijendar.mukunda@....com>
To: Vinod Koul <vkoul@...nel.org>
Cc: yung-chuan.liao@...ux.intel.com, pierre-louis.bossart@...ux.dev,
 sanyog.r.kale@...el.com, Basavaraj.Hiregoudar@....com,
 Sunil-kumar.Dommati@....com, venkataprasad.potturu@....com,
 Mario.Limonciello@....com, linux-sound@...r.kernel.org,
 linux-kernel@...r.kernel.org, alsa-devel@...a-project.org
Subject: Re: [PATCH RESEND] soundwire: amd: clear wake enable register for

On 23/12/24 11:38, Vinod Koul wrote:
> On 03-12-24, 14:40, Vijendar Mukunda wrote:
>
> for...? Pls write the full subject
Patch commit title was not updated properly.
I have already respin the patch by updating the subject.
Sent a mail to ignore this patch as commit message is incomplete.
>
>> As per design for power off mode, clear the wake enable register during
>> resume sequence.
>>
>> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@....com>
>> ---
>>  drivers/soundwire/amd_manager.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manager.c
>> index 5a4bfaef65fb..96a3aa6da711 100644
>> --- a/drivers/soundwire/amd_manager.c
>> +++ b/drivers/soundwire/amd_manager.c
>> @@ -1190,6 +1190,7 @@ static int __maybe_unused amd_resume_runtime(struct device *dev)
>>  	if (amd_manager->power_mode_mask & AMD_SDW_CLK_STOP_MODE) {
>>  		return amd_sdw_clock_stop_exit(amd_manager);
>>  	} else if (amd_manager->power_mode_mask & AMD_SDW_POWER_OFF_MODE) {
>> +		writel(0x00, amd_manager->acp_mmio + ACP_SW_WAKE_EN(amd_manager->instance));
> no need for 0x for a zero value
Will fix it and post v2 version.
>
>>  		val = readl(amd_manager->mmio + ACP_SW_CLK_RESUME_CTRL);
>>  		if (val) {
>>  			val |= AMD_SDW_CLK_RESUME_REQ;
>> -- 
>> 2.34.1