linux-kernel - Re: [PATCH v1] usb: dwc3: gadget: Fix incorrect UDC state after manual deconfiguration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f06eb1fb7fa12880b04310d702e1b06af5b25276.camel@linaro.org>
Date: Mon, 23 Dec 2024 06:51:15 +0000
From: André Draszik <andre.draszik@...aro.org>
To: Roy Luo <royluo@...gle.com>, Thinh.Nguyen@...opsys.com, 
	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Cc: badhri@...gle.com, peter.griffin@...aro.org
Subject: Re: [PATCH v1] usb: dwc3: gadget: Fix incorrect UDC state after
 manual deconfiguration

On Mon, 2024-12-23 at 04:25 +0000, Roy Luo wrote:
> The UDC state in sysfs (/sys/class/udc/<udc>/state) should accurately
> reflect the current state of the USB Device Controller.
> 
> Currently, the UDC state is not handled consistently during gadget
> disconnection. While the disconnect interrupt path correctly sets the
> state to "not-attached", manual deconfiguration leaves the state in
> "configured", misrepresenting the actual situation.
> 
> This commit ensures consistent UDC state handling by setting the state to
> "not-attached" after manual deconfiguration. This accurately reflects the
> UDC's state and provides a consistent behavior regardless of the
> disconnection method.
> 
> Signed-off-by: Roy Luo <royluo@...gle.com>
> ---

Reviewed-by: André Draszik <andre.draszik@...aro.org>
Tested-by: André Draszik <andre.draszik@...aro.org>