linux-kernel - Re: [RESEND PATCH] powerpc: Use str_on_off() helper in check_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87o712lwj5.fsf@gmail.com>
Date: Mon, 23 Dec 2024 12:24:06 +0530
From: Ritesh Harjani (IBM) <ritesh.list@...il.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>, Michael Ellerman
 <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>, Christophe
 Leroy <christophe.leroy@...roup.eu>, Naveen N Rao <naveen@...nel.org>,
 Madhavan Srinivasan <maddy@...ux.ibm.com>, Hari Bathini
 <hbathini@...ux.ibm.com>, Thomas Gleixner <tglx@...utronix.de>, Thorsten
 Blum <thorsten.blum@...ux.dev>, Thomas Weißschuh
 <thomas.weissschuh@...utronix.de>, Baoquan He <bhe@...hat.com>
Cc: linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] powerpc: Use str_on_off() helper in check_cache_coherency()

Thorsten Blum <thorsten.blum@...ux.dev> writes:

> Remove hard-coded strings by using the str_on_off() helper function.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>  arch/powerpc/kernel/setup-common.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
> index 6fa179448c33..f7d7a93f07fc 100644
> --- a/arch/powerpc/kernel/setup-common.c
> +++ b/arch/powerpc/kernel/setup-common.c
> @@ -834,8 +834,8 @@ static int __init check_cache_coherency(void)
>  	if (devtree_coherency != KERNEL_COHERENCY) {
>  		printk(KERN_ERR
>  			"kernel coherency:%s != device tree_coherency:%s\n",
> -			KERNEL_COHERENCY ? "on" : "off",
> -			devtree_coherency ? "on" : "off");
> +			str_on_off(KERNEL_COHERENCY),
> +			str_on_off(devtree_coherency));
>  		BUG();
>  	}


Looks good to me. Please feel free to add - 
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@...il.com>

-ritesh