linux-kernel - Re: [PATCH v7] mm/memblock: Add memblock_alloc_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6ac0e0f71990e5a8dc52f00c737cdf56916e0d4e.camel@xry111.site>
Date: Mon, 23 Dec 2024 15:15:34 +0800
From: Xi Ruoyao <xry111@...111.site>
To: Mike Rapoport <rppt@...nel.org>, Guo Weikang
 <guoweikang.kernel@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Geert Uytterhoeven	
 <geert@...ux-m68k.org>, Dennis Zhou <dennis@...nel.org>, Tejun Heo
 <tj@...nel.org>,  Christoph Lameter	 <cl@...ux.com>, Thomas Bogendoerfer
 <tsbogend@...ha.franken.de>, Sam Creasey	 <sammy@...my.net>, Huacai Chen
 <chenhuacai@...nel.org>, Will Deacon	 <will@...nel.org>, Catalin Marinas
 <catalin.marinas@....com>, Oreoluwa Babatunde <quic_obabatun@...cinc.com>,
 rafael.j.wysocki@...el.com, Palmer Dabbelt <palmer@...osinc.com>,  Hanjun
 Guo <guohanjun@...wei.com>, Easwar Hariharan
 <eahariha@...ux.microsoft.com>, Johannes Berg	 <johannes.berg@...el.com>,
 Ingo Molnar <mingo@...nel.org>, Dave Hansen	 <dave.hansen@...el.com>,
 Christian Brauner <brauner@...nel.org>, KP Singh	 <kpsingh@...nel.org>,
 Richard Henderson <richard.henderson@...aro.org>, Matt Turner
 <mattst88@...il.com>, Russell King <linux@...linux.org.uk>, WANG Xuerui
 <kernel@...0n.name>,  Michael Ellerman <mpe@...erman.id.au>, Stefan
 Kristiansson <stefan.kristiansson@...nalahti.fi>, Stafford Horne	
 <shorne@...il.com>, Helge Deller <deller@....de>, Nicholas Piggin	
 <npiggin@...il.com>, Christophe Leroy <christophe.leroy@...roup.eu>, Naveen
 N Rao <naveen@...nel.org>, Madhavan Srinivasan <maddy@...ux.ibm.com>, Geoff
 Levand	 <geoff@...radead.org>, Paul Walmsley <paul.walmsley@...ive.com>,
 Palmer Dabbelt	 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Andrey Ryabinin	 <ryabinin.a.a@...il.com>, Alexander Potapenko
 <glider@...gle.com>, Andrey Konovalov <andreyknvl@...il.com>, Dmitry Vyukov
 <dvyukov@...gle.com>, Vincenzo Frascino	 <vincenzo.frascino@....com>, Heiko
 Carstens <hca@...ux.ibm.com>, Vasily Gorbik	 <gor@...ux.ibm.com>, Alexander
 Gordeev <agordeev@...ux.ibm.com>, Christian Borntraeger
 <borntraeger@...ux.ibm.com>, Sven Schnelle <svens@...ux.ibm.com>, Yoshinori
 Sato	 <ysato@...rs.sourceforge.jp>, Rich Felker <dalias@...c.org>, John
 Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>, Andreas Larsson
 <andreas@...sler.com>, Richard Weinberger	 <richard@....at>, Anton Ivanov
 <anton.ivanov@...bridgegreys.com>, Johannes Berg	
 <johannes@...solutions.net>, Thomas Gleixner <tglx@...utronix.de>, Ingo
 Molnar	 <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, Dave Hansen	
 <dave.hansen@...ux.intel.com>, x86@...nel.org, linux-alpha@...r.kernel.org,
 	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	loongarch@...ts.linux.dev, linux-m68k@...ts.linux-m68k.org, 
	linux-mips@...r.kernel.org, linux-openrisc@...r.kernel.org, 
	linux-parisc@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, 
	linux-riscv@...ts.infradead.org, kasan-dev@...glegroups.com, 
	linux-s390@...r.kernel.org, linux-sh@...r.kernel.org,
 sparclinux@...r.kernel.org, 	linux-um@...ts.infradead.org,
 linux-acpi@...r.kernel.org, 	xen-devel@...ts.xenproject.org,
 linux-omap@...r.kernel.org, 	linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-mm@...ck.org, 	linux-pm@...r.kernel.org
Subject: Re: [PATCH v7] mm/memblock: Add memblock_alloc_or_panic interface

On Mon, 2024-12-23 at 09:12 +0200, Mike Rapoport wrote:
> On Sun, Dec 22, 2024 at 07:15:37PM +0800, Guo Weikang wrote:
> > Before SLUB initialization, various subsystems used memblock_alloc to
> > allocate memory. In most cases, when memory allocation fails, an immediate
> > panic is required. To simplify this behavior and reduce repetitive checks,
> > introduce `memblock_alloc_or_panic`. This function ensures that memory
> > allocation failures result in a panic automatically, improving code
> > readability and consistency across subsystems that require this behavior.
> > 
> > Changelog:
> > ----------
> > v1: initial version
> > v2: add __memblock_alloc_or_panic support panic output caller
> > v3: panic output phys_addr_t use printk's %pap
> > v4: make __memblock_alloc_or_panic out-of-line, move to memblock.c
> > v6: Fix CI compile error
> > Links to CI: https://lore.kernel.org/oe-kbuild-all/202412221000.r1NzXJUO-lkp@intel.com/
> > v6: Fix CI compile warinigs
> > Links to CI: https://lore.kernel.org/oe-kbuild-all/202412221259.JuGNAUCq-lkp@intel.com/
> > v7: add chagelog and adjust function declaration alignment format
> > ----------
> > 
> > Signed-off-by: Guo Weikang <guoweikang.kernel@...il.com>
> > Reviewed-by: Andrew Morton <akpm@...ux-foundation.org>
> > Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> > Reviewed-by: Mike Rapoport (Microsoft) <rppt@...nel.org>
> > Acked-by: Xi Ruoyao <xry111@...111.site>
> 
> If people commented on your patch it does not mean you should add
> Reviewed-by or Acked-by tags for them. Wait for explicit tags from the
> reviewers.

And:

 - Acked-by: indicates an agreement by another developer (often a
   maintainer of the relevant code) that the patch is appropriate for
   inclusion into the kernel. 

I'm not a maintainer so I even don't have the right to use Acked-by :).

-- 
Xi Ruoyao <xry111@...111.site>
School of Aerospace Science and Technology, Xidian University