linux-kernel - Re: [PATCH 10/11] VFS: take a shared lock for create/remove directory operations.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241223072655.GM1977892@ZenIV>
Date: Mon, 23 Dec 2024 07:26:55 +0000
From: Al Viro <viro@...iv.linux.org.uk>
To: NeilBrown <neilb@...e.de>
Cc: Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/11] VFS: take a shared lock for create/remove
 directory operations.

On Mon, Dec 23, 2024 at 06:11:16PM +1100, NeilBrown wrote:
> ... Yes, thanks.
> 
> So I need __d_unalias() to effectively do a "try_lock" of
> DCACHE_PAR_UPDATE and hold the lock across __d_move().
> I think that would address the concerned you raised.
> 
> Did you see anything else that might be problematic?

That might work with ->d_parent, but it won't help with ->d_name
in same-parent case of __d_unalias()...