linux-kernel - Re: drivers/firmware/broadcom/tee_bnxt_fw.c:62: warning: Function parameter or struct member 'fw_shm_pool' not described in 'tee_bnxt_fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z2i6XCqTXdp/cgcc@rli9-mobl>
Date: Mon, 23 Dec 2024 09:18:20 +0800
From: Philip Li <philip.li@...el.com>
To: kernel test robot <lkp@...el.com>
CC: Arnd Bergmann <arnd@...db.de>, <llvm@...ts.linux.dev>,
	<oe-kbuild-all@...ts.linux.dev>, <linux-kernel@...r.kernel.org>, "Bjorn
 Andersson" <andersson@...nel.org>, Charles Keepax
	<ckeepax@...nsource.cirrus.com>, Mark Brown <broonie@...nel.org>
Subject: Re: drivers/firmware/broadcom/tee_bnxt_fw.c:62: warning: Function
 parameter or struct member 'fw_shm_pool' not described in
 'tee_bnxt_fw_private'

On Mon, Dec 23, 2024 at 06:12:39AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   bcde95ce32b666478d6737219caa4f8005a8f201
> commit: 951cd3a0866d29cb9c01ebc1d9c17590e598226e firmware: include drivers/firmware/Kconfig unconditionally
> date:   3 years, 3 months ago
> config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20241223/202412230640.Xkdah4yq-lkp@intel.com/config)
> compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 9daf10ff8f29ba3a88a105aaa9d2379c21b77d35)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241223/202412230640.Xkdah4yq-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202412230640.Xkdah4yq-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):

Sorry, kindly ignore this report that the found commit is not the root cause.

> 
> >> drivers/firmware/broadcom/tee_bnxt_fw.c:62: warning: Function parameter or struct member 'fw_shm_pool' not described in 'tee_bnxt_fw_private'
> --
> >> drivers/firmware/broadcom/bcm47xx_nvram.c:41: warning: Function parameter or struct member 'nvram' not described in 'bcm47xx_nvram_is_valid'
> >> drivers/firmware/broadcom/bcm47xx_nvram.c:49: warning: Function parameter or struct member 'nvram_start' not described in 'bcm47xx_nvram_copy'
> >> drivers/firmware/broadcom/bcm47xx_nvram.c:49: warning: Function parameter or struct member 'res_size' not described in 'bcm47xx_nvram_copy'
> >> drivers/firmware/broadcom/bcm47xx_nvram.c:73: warning: Function parameter or struct member 'flash_start' not described in 'bcm47xx_nvram_find_and_copy'
> >> drivers/firmware/broadcom/bcm47xx_nvram.c:73: warning: Function parameter or struct member 'res_size' not described in 'bcm47xx_nvram_find_and_copy'
> 
> 
> vim +62 drivers/firmware/broadcom/tee_bnxt_fw.c
> 
> 246880958ac939 Vikas Gupta 2019-10-31  50  
> 246880958ac939 Vikas Gupta 2019-10-31  51  /**
> 246880958ac939 Vikas Gupta 2019-10-31  52   * struct tee_bnxt_fw_private - OP-TEE bnxt private data
> 246880958ac939 Vikas Gupta 2019-10-31  53   * @dev:		OP-TEE based bnxt device.
> 246880958ac939 Vikas Gupta 2019-10-31  54   * @ctx:		OP-TEE context handler.
> 246880958ac939 Vikas Gupta 2019-10-31  55   * @session_id:		TA session identifier.
> 246880958ac939 Vikas Gupta 2019-10-31  56   */
> 246880958ac939 Vikas Gupta 2019-10-31  57  struct tee_bnxt_fw_private {
> 246880958ac939 Vikas Gupta 2019-10-31  58  	struct device *dev;
> 246880958ac939 Vikas Gupta 2019-10-31  59  	struct tee_context *ctx;
> 246880958ac939 Vikas Gupta 2019-10-31  60  	u32 session_id;
> 246880958ac939 Vikas Gupta 2019-10-31  61  	struct tee_shm *fw_shm_pool;
> 246880958ac939 Vikas Gupta 2019-10-31 @62  };
> 246880958ac939 Vikas Gupta 2019-10-31  63  
> 
> :::::: The code at line 62 was first introduced by commit
> :::::: 246880958ac93989c97c73ae1e60b78b4c4c88c5 firmware: broadcom: add OP-TEE based BNXT f/w manager
> 
> :::::: TO: Vikas Gupta <vikas.gupta@...adcom.com>
> :::::: CC: David S. Miller <davem@...emloft.net>
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
>