linux-kernel - Re: [PATCH v3 3/3] virtio-spi: Add virtio SPI driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241223110026.371-1-hdanton@sina.com>
Date: Mon, 23 Dec 2024 19:00:22 +0800
From: Hillf Danton <hdanton@...a.com>
To: Harald Mommer <Harald.Mommer@...nsynergy.com>
Cc: virtio-dev@...ts.oasis-open.org,
	Mark Brown <broonie@...nel.org>,
	Viresh Kumar <viresh.kumar@...aro.org>,
	linux-spi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] virtio-spi: Add virtio SPI driver.

On Tue, 26 Mar 2024 12:28:12 +0100 Harald Mommer <Harald.Mommer@...nsynergy.com>
> +	/* Prepare sending of virtio message */
> +	reinit_completion(&spi_req->completion);
> +
Why is reinit needed, given init?

> +	ret = virtqueue_add_sgs(priv->vq, sgs, outcnt, incnt, spi_req,
> +				GFP_KERNEL);
> +	if (ret)
> +		goto msg_done;
> +
> +	/* Simple implementation: There can be only one transfer in flight */
> +	virtqueue_kick(priv->vq);
> +
> +	wait_for_completion(&priv->spi_req.completion);