linux-kernel - Re: [PATCH 08/16] media: qcom: camss: vfe: Move common code into vfe core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <697738c6-6867-4a7f-b0a8-8b425413ae65@quicinc.com>
Date: Mon, 23 Dec 2024 19:55:35 +0800
From: Depeng Shao <quic_depengs@...cinc.com>
To: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
        Bryan O'Donoghue
	<bryan.odonoghue@...aro.org>, <rfoss@...nel.org>,
        <todor.too@...il.com>, <mchehab@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>
CC: <quic_eberman@...cinc.com>, <linux-media@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kernel@...cinc.com>
Subject: Re: [PATCH 08/16] media: qcom: camss: vfe: Move common code into vfe
 core

Hi Vladimir, Bryan,

On 12/12/2024 3:57 PM, Vladimir Zapolskiy wrote:
> On 12/12/24 03:35, Bryan O'Donoghue wrote:
>> On 12/12/2024 01:06, Vladimir Zapolskiy wrote:
>>>
>>> This is a massive and a functional change
>>
>> It shouldn't be a _functional_ change at all, just a refactoring and a
>> reduction.
> 
> I've just tested that this change breaks not only TPG on SM8250/RB5, but
> a regular image capturing from imx577 camera sensor is also broken.
> 
> Hope it helps.
> 

I will remove a modification to update the enable_irq order in this 
patch which is asked by Bryan in v4 patches [1] and make sure there is 
no logical change between old code and new refactor code, in case any 
regression in this change.

>> I'll take a look too, see if I can spot a regression on rb3-gen1 and
>> replicate the breakage on rb5.
>>
> 
> Thank you, very much appreciated. Splitting the change would be still
> welcome.
> 
>> @Depeng we can probably get you remote access to an RB5 if you need it.
>>
> 

[1] 
https://lore.kernel.org/all/47aa934d-bdad-4c76-9420-ce65950f67d1@linaro.org/

Thanks,
Depeng