linux-kernel - Re: [PATCH v3 1/7] mfd: Add core driver for Nuvoton NCT6694

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOoeyxWpZF3-cdcT=yawRddADwyH5La0bMB+i3ic1O-TiFb9Cw@mail.gmail.com>
Date: Mon, 23 Dec 2024 10:04:45 +0800
From: Ming Yu <a0282524688@...il.com>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: tmyu0@...oton.com, lee@...nel.org, brgl@...ev.pl, andi.shyti@...nel.org, 
	mkl@...gutronix.de, mailhol.vincent@...adoo.fr, andrew+netdev@...n.ch, 
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, 
	wim@...ux-watchdog.org, linux@...ck-us.net, jdelvare@...e.com, 
	alexandre.belloni@...tlin.com, linux-kernel@...r.kernel.org, 
	linux-gpio@...r.kernel.org, linux-i2c@...r.kernel.org, 
	linux-can@...r.kernel.org, netdev@...r.kernel.org, 
	linux-watchdog@...r.kernel.org, linux-hwmon@...r.kernel.org, 
	linux-rtc@...r.kernel.org
Subject: Re: [PATCH v3 1/7] mfd: Add core driver for Nuvoton NCT6694

Dear Linus,

Thank you for your reply,

Linus Walleij <linus.walleij@...aro.org> 於 2024年12月20日 週五 下午8:45寫道：
>
> Hi Ming,
>
> thanks for your patch!
>
...
> > +       while (*int_status) {
> > +               int irq = __ffs(*int_status);
> > +
> > +               if (*int_status & (1 << irq))
> > +                       generic_handle_irq_safe(irq_find_mapping(nct6694->domain, irq));
> > +
> > +               *int_status &= ~(1 << irq);
>
> What about doing what you do in the GPIO driver and
> #include <linux/bits.h>
>
> And search and replace "(1 << irq)" with BIT(irq)?
>
> PS the main reason we do this is because
>
> int a = (1 << 31);
>
> becomes a negative number on 32bit machines, and
> can lead to confusing side effects. BIT() always work
> on unsigned.
>

Understood! I will make the modifications in the v4.

Best regards,
Ming