linux-kernel - Re: [PATCH v5] pinctrl: stm32: Add check for clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAN4iqtRuj9M=GzFbY-hY4Ks3ktSKfA2W5yLT19vkJ2CSe1it9Q@mail.gmail.com>
Date: Sun, 22 Dec 2024 21:23:43 -0500
From: Mingwei Zheng <zmw12306@...il.com>
To: Marek Vasut <marex@...x.de>
Cc: antonio.borneo@...s.st.com, linus.walleij@...aro.org, 
	mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com, make24@...as.ac.cn, 
	peng.fan@....com, fabien.dessenne@...s.st.com, linux-gpio@...r.kernel.org, 
	linux-stm32@...md-mailman.stormreply.com, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	Jiasheng Jiang <jiashengjiangcool@...il.com>
Subject: Re: [PATCH v5] pinctrl: stm32: Add check for clk_enable()

Hi Marek,

On Sun, Dec 15, 2024 at 6:54 PM Marek Vasut <marex@...x.de> wrote:
>
> On 12/15/24 9:40 PM, Mingwei Zheng wrote:
>
> [...]
>
> > @@ -1617,10 +1602,18 @@ int stm32_pctl_probe(struct platform_device *pdev)
> >               return -EINVAL;
> >       }
> >       pctl->banks = devm_kcalloc(dev, banks, sizeof(*pctl->banks),
> > -                     GFP_KERNEL);
> > +                                GFP_KERNEL);
>
> Please drop this one change.

Fixed in PATCH v6.

>
> >       if (!pctl->banks)
> >               return -ENOMEM;
> >
> > +     pctl->clks = devm_kcalloc(dev, banks, sizeof(*pctl->clks),
> > +                               GFP_KERNEL);
> > +     if (!pctl->clks)
> > +             return -ENOMEM;
> > +
> > +     for (i = 0; i < banks; ++i)
> > +             pctl->clks[i].id = "";
>
> Is this ^ assignment necessary ? If so, why ?
>
> [...]

Thanks for pointing this out. We call devm_clk_bulk_get_all in
stm32_pctl_probe() to handle get clk in PATCH v6.

Best,
Mingwei