linux-kernel - Re: [PATCH v2 1/3] dt-bindings: platform: Add bindings for Qcom's EC on IT8987

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <26ba3710-9f7f-40ae-a65d-e1d6e384a142@kernel.org>
Date: Mon, 23 Dec 2024 15:25:23 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Maya Matuszczyk <maccraft123mc@...il.com>
Cc: Stephan Gerhold <stephan.gerhold@...aro.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
 devicetree <devicetree@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: platform: Add bindings for Qcom's EC
 on IT8987

On 22/12/2024 16:07, Maya Matuszczyk wrote:
> 
> With similar ones at the end:
> Devkit:
> EC VER:00.29.00$
> LsFv:00.29.00$
> Qualcomm$
> WoS 8c GenX$
> ODM$
> MB:A0$
> BUILD DATE:
> 02/0//2/24$
> TIME:
> 14:33:35$
> 
> Slim7x:
> EC VER:00.60.00$
> LsFv:00.20.00$
> Qualcomm$
> WoS 8c GenX$
> ODM$
> MB:A0$
> BUILD DATE:
> 2024/07/25$
> TIME:
> 09:58:00$
> 
> 
> 
>>
>> If the FW across devices is the same, then fallbacks for these are fine
>> with me.
> 
> As the devkit has EC firmware that is handled the same way in DSDT
> tables of most of other x1e laptops with the same EC, and is a subset
> of what's done on Lenovo Yoga Slim 7x and Honor Magicbook Art 14 I
> think the devkit's compatible  + -ec would be a good pick.
> 
> This conversation is getting long and I feel like I've said everything
> I wanted to say, I'll just do what you tell me to do about the
> fallback and binding filename.

Go with a device specific compatible (I think I proposed in other
email). It is up to you if you want to add fallbacks. If you add
fallbacks, then please include some summary of above in commit msg or
binding description, so there will be a trace of that explanation/reason
for fallbacks.

Best regards,
Krzysztof