linux-kernel - Re: [PATCH v3 1/6] dt-bindings: PCI: Add binding for qps615

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bf57eca8-69b5-9c21-0350-bf1c07de786f@quicinc.com>
Date: Mon, 23 Dec 2024 22:18:24 +0530
From: Krishna Chaitanya Chundru <quic_krichai@...cinc.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Bjorn Helgaas
	<helgaas@...nel.org>, Rob Herring <robh@...nel.org>
CC: <andersson@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
        "Lorenzo
 Pieralisi" <lpieralisi@...nel.org>,
        Krzysztof Wilczyński
	<kw@...ux.com>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Konrad Dybcio
	<konradybcio@...nel.org>,
        <cros-qcom-dts-watchers@...omium.org>,
        Jingoo Han
	<jingoohan1@...il.com>,
        Bartosz Golaszewski <brgl@...ev.pl>, <quic_vbadigan@...cinc.com>,
        <linux-arm-msm@...r.kernel.org>, <linux-pci@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/6] dt-bindings: PCI: Add binding for qps615



On 12/11/2024 11:30 AM, Manivannan Sadhasivam wrote:
> On Wed, Dec 04, 2024 at 03:25:59PM -0600, Bjorn Helgaas wrote:
>> On Tue, Nov 12, 2024 at 08:31:33PM +0530, Krishna chaitanya chundru wrote:
>>> Add binding describing the Qualcomm PCIe switch, QPS615,
>>> which provides Ethernet MAC integrated to the 3rd downstream port
>>> and two downstream PCIe ports.
>>
>>> +$defs:
>>> +  qps615-node:
>>> +    type: object
>>> +
>>> +    properties:
>>> +      qcom,l0s-entry-delay-ns:
>>> +        description: Aspm l0s entry delay.
>>> +
>>> +      qcom,l1-entry-delay-ns:
>>> +        description: Aspm l1 entry delay.
>>
>> To match spec usage:
>> s/Aspm/ASPM/
>> s/l0s/L0s/
>> s/l1/L1/
>>
>> Other than the fact that qps615 needs the driver to configure these,
>> there's nothing qcom-specific here, so I suggest the names should omit
>> "qcom" and include "aspm".
>>
> 
> In that case, these properties should be documented in dt-schema:
> https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/pci/pci-bus-common.yaml
> 
> - Mani
I am fine to move to pci-bus-common.yaml but currently these are being 
used by qps615 only I hope that is fine.

- Krishna Chaitanya.
>