| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <74c43172-b55e-4c50-8a6d-061f616748d7@arm.com> Date: Mon, 23 Dec 2024 17:06:01 +0000 From: Steven Price <steven.price@....com> To: Karunika Choo <karunika.choo@....com>, dri-devel@...ts.freedesktop.org Cc: nd@....com, Boris Brezillon <boris.brezillon@...labora.com>, Liviu Dudau <liviu.dudau@....com>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, linux-kernel@...r.kernel.org Subject: Re: [RFC PATCH 1/4] drm/panthor: Add 64-bit register accessors On 19/12/2024 17:05, Karunika Choo wrote: > This patch adds 64-bit register accessors to simplify register access in > Panthor. It also adds 64-bit variants for read_poll_timeout and replaces > all 64-bit and poll register accesses with these new functions. > > Signed-off-by: Karunika Choo <karunika.choo@....com> (Minor NIT: This might be easier to review as two patches - one which adds the new functions and a second which switching the code over to use them). [...] > diff --git a/drivers/gpu/drm/panthor/panthor_regs.h b/drivers/gpu/drm/panthor/panthor_regs.h > index b7b3b3add166..269c2c68dde2 100644 > --- a/drivers/gpu/drm/panthor/panthor_regs.h > +++ b/drivers/gpu/drm/panthor/panthor_regs.h > @@ -10,6 +10,9 @@ > #ifndef __PANTHOR_REGS_H__ > #define __PANTHOR_REGS_H__ > > +#include <linux/iopoll.h> > + > +/* GX10 registers */ NIT: Please don't include unrelated changes like this comment. Other than those minor issues, this looks like a nice improvement. Steve
Powered by blists - more mailing lists