linux-kernel - Re: [PATCH v3 06/10] mtd: intel-dg: wake card on operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87cyhiqk7a.fsf@bootlin.com>
Date: Mon, 23 Dec 2024 20:21:29 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: "Usyskin, Alexander" <alexander.usyskin@...el.com>
Cc: "Poosa, Karthik" <karthik.poosa@...el.com>,  "Vivi, Rodrigo"
 <rodrigo.vivi@...el.com>,  Richard Weinberger <richard@....at>,  Vignesh
 Raghavendra <vigneshr@...com>,  "De Marchi, Lucas"
 <lucas.demarchi@...el.com>,  Thomas Hellström
 <thomas.hellstrom@...ux.intel.com>,  Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>,  Maxime Ripard <mripard@...nel.org>,
  Thomas Zimmermann <tzimmermann@...e.de>,  David Airlie
 <airlied@...il.com>,  Simona Vetter <simona@...ll.ch>,  Jani Nikula
 <jani.nikula@...ux.intel.com>,  Joonas Lahtinen
 <joonas.lahtinen@...ux.intel.com>,  Tvrtko Ursulin <tursulin@...ulin.net>,
  "Weil, Oren jer" <oren.jer.weil@...el.com>,
  "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
  "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
  "intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
  "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 06/10] mtd: intel-dg: wake card on operations

Hello Alexander,

>> If so, I have to add patch for mtd subsystem to always have device for master
>> initialized regardless of kernel flag.
>> Only to initialize struct device, not to create full mtd node.
>> 
>> Miquel - are you agree to this?

Conceptually yes, but please mind one thing: we do not break
userspace. So if you want to keep the master mtd device, fine, but you
need to do it in a consistent way so that people not enabling the kernel
flag won't get a new device in their rootfs, shifting all indexes
upwards.

That being said, you are probably going in the right direction by doing
that.

Thanks,
Miquèl