linux-kernel - Re: [PATCH 01/11] x86/mm: make MMU_GATHER_RCU_TABLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53c9c3784a8136f41ac3c6ec3725af406f5394a5.camel@surriel.com>
Date: Mon, 23 Dec 2024 15:20:25 -0500
From: Rik van Riel <riel@...riel.com>
To: Qi Zheng <zhengqi.arch@...edance.com>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org, kernel-team@...a.com, 
	dave.hansen@...ux.intel.com, luto@...nel.org, peterz@...radead.org, 
	tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, hpa@...or.com, 
	akpm@...ux-foundation.org, linux-mm@...ck.org
Subject: Re: [PATCH 01/11] x86/mm: make MMU_GATHER_RCU_TABLE_FREE
 unconditional

On Mon, 2024-12-23 at 14:01 +0800, Qi Zheng wrote:
> Very happy to see this change!
> 
> 
> > @@ -191,7 +186,7 @@ struct paravirt_patch_template pv_ops = {
> >   	.mmu.flush_tlb_kernel	= native_flush_tlb_global,
> >   	.mmu.flush_tlb_one_user	=
> > native_flush_tlb_one_user,
> >   	.mmu.flush_tlb_multi	= native_flush_tlb_multi,
> > -	.mmu.tlb_remove_table	= native_tlb_remove_table,
> > +	.mmu.tlb_remove_table	= tlb_remove_table,
> >   
> >   	.mmu.exit_mmap		= paravirt_nop,
> >   	.mmu.notify_page_enc_status_changed	= paravirt_nop,
> 
> It look like this patch series is not based on the latest linux-next.
> 
That is correct. I based this on tip.git x86/mm, since
that seems like the most likely destination for this
code.

> In addition to the above case, maybe the paravirt_tlb_remove_table()
> in arch/x86/mm/pgtable.c also needs to be changed to
> tlb_remove_table()?

I'll get that in the next version.

Thank you for reviewing the patch!

-- 
All Rights Reversed.