linux-kernel - Re: [PATCH 1/4] RDMA/core: Remove unused ib_ud_header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH-L+nPGG6kcwwNgwT6a5ZBn7qSY56nSKJV0D_XQH57CnO164A@mail.gmail.com>
Date: Mon, 23 Dec 2024 08:59:50 +0530
From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>
To: linux@...blig.org
Cc: jgg@...pe.ca, leon@...nel.org, linux-rdma@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] RDMA/core: Remove unused ib_ud_header_unpack

On Sat, Dec 21, 2024 at 7:11 AM <linux@...blig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>
> ib_ud_header_unpack() is unused, and I can't see any sign of it
> ever having been used in git.  The only reference I can find
> is from December 2004 BKrev: 41d30034XNbBUl0XnyC6ig9V61Nf-A when
> it looks like it was added.
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> ---
>  drivers/infiniband/core/ud_header.c | 83 -----------------------------
>  include/rdma/ib_pack.h              |  3 --
>  2 files changed, 86 deletions(-)
>
> diff --git a/drivers/infiniband/core/ud_header.c b/drivers/infiniband/core/ud_header.c
> index 64d9c492de64..8d3dfef9ebaa 100644
> --- a/drivers/infiniband/core/ud_header.c
> +++ b/drivers/infiniband/core/ud_header.c
> @@ -462,86 +462,3 @@ int ib_ud_header_pack(struct ib_ud_header *header,
>         return len;

LGTM,
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@...adcom.com>

-- 
Regards,
Kalesh AP

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4239 bytes)