linux-kernel - Re: [PATCH] fs: erofs: xattr.c change kzalloc to kcalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <80a3e6ab-839e-47b6-9554-fbaf330ab4b8@linux.alibaba.com>
Date: Mon, 23 Dec 2024 11:32:19 +0800
From: Gao Xiang <hsiangkao@...ux.alibaba.com>
To: Ethan Carter Edwards <ethan@...ancedwards.com>,
 "xiang@...nel.org" <xiang@...nel.org>
Cc: "zbestahu@...il.com" <zbestahu@...il.com>,
 "linux-erofs@...ts.ozlabs.org" <linux-erofs@...ts.ozlabs.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs: erofs: xattr.c change kzalloc to kcalloc



On 2024/12/23 11:00, Ethan Carter Edwards wrote:
>  From 272d7ef4611e64269fada0ea3021eece590118b9 Mon Sep 17 00:00:00 2001
> From: Ethan Carter Edwards <ethan@...ancedwards.com>
> Date: Sun, 22 Dec 2024 21:23:56 -0500
> Subject: [PATCH] fs: erofs: xattr.c change kzalloc to kcalloc
> 
> Refactor xattr.c to use kcalloc instead of kzalloc when multiplying
> allocation size by count. This refactor prevents unintentional
> memory overflows. Discovered by checkpatch.pl.
> 
> Signed-off-by: Ethan Carter Edwards <ethan@...ancedwards.com>

Reviewed-by: Gao Xiang <hsiangkao@...ux.alibaba.com>

Although your raw patch format is incorrect.  You shouldn't
send the whole patch as the content, but just use
`git send-email` to send the patch.

I've fixed it up manually, no need to resend.

Thanks,
Gao Xiang

> ---
>   fs/erofs/xattr.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/erofs/xattr.c b/fs/erofs/xattr.c
> index a90d7d649739..7940241d9355 100644
> --- a/fs/erofs/xattr.c
> +++ b/fs/erofs/xattr.c
> @@ -478,7 +478,7 @@ int erofs_xattr_prefixes_init(struct super_block *sb)
>   	if (!sbi->xattr_prefix_count)
>   		return 0;
>   
> -	pfs = kzalloc(sbi->xattr_prefix_count * sizeof(*pfs), GFP_KERNEL);
> +	pfs = kcalloc(sbi->xattr_prefix_count, sizeof(*pfs), GFP_KERNEL);
>   	if (!pfs)
>   		return -ENOMEM;
>