linux-kernel - drivers/hwmon/aht10.c:182: warning: Function parameter or struct member 'data' not described in 'aht10_interval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202412240737.3JBrlh9w-lkp@intel.com>
Date: Tue, 24 Dec 2024 08:07:14 +0800
From: kernel test robot <lkp@...el.com>
To: "Johannes Cornelis Draaijer (datdenkikniet)" <jcdra1@...il.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Guenter Roeck <linux@...ck-us.net>
Subject: drivers/hwmon/aht10.c:182: warning: Function parameter or struct
 member 'data' not described in 'aht10_interval_write'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   f07044dd0df0c9d0ad177c3098b62ccddb735a2d
commit: 8c78f0dee4371ab3b0422edf08597525c6219512 hwmon: Add AHT10 Temperature and Humidity Sensor Driver
date:   3 years, 11 months ago
config: arm64-randconfig-001-20241212 (https://download.01.org/0day-ci/archive/20241224/202412240737.3JBrlh9w-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241224/202412240737.3JBrlh9w-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412240737.3JBrlh9w-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/hwmon/aht10.c:87: warning: Excess function parameter 'client' description in 'aht10_init'
   drivers/hwmon/aht10.c:131: warning: Function parameter or struct member 'data' not described in 'aht10_read_values'
   drivers/hwmon/aht10.c:131: warning: Excess function parameter 'aht10_data' description in 'aht10_read_values'
>> drivers/hwmon/aht10.c:182: warning: Function parameter or struct member 'data' not described in 'aht10_interval_write'
>> drivers/hwmon/aht10.c:182: warning: Function parameter or struct member 'val' not described in 'aht10_interval_write'
>> drivers/hwmon/aht10.c:193: warning: Function parameter or struct member 'data' not described in 'aht10_interval_read'
>> drivers/hwmon/aht10.c:193: warning: Function parameter or struct member 'val' not described in 'aht10_interval_read'
>> drivers/hwmon/aht10.c:202: warning: Function parameter or struct member 'data' not described in 'aht10_temperature1_read'
>> drivers/hwmon/aht10.c:202: warning: Function parameter or struct member 'val' not described in 'aht10_temperature1_read'
>> drivers/hwmon/aht10.c:217: warning: Function parameter or struct member 'data' not described in 'aht10_humidity1_read'
>> drivers/hwmon/aht10.c:217: warning: Function parameter or struct member 'val' not described in 'aht10_humidity1_read'


vim +182 drivers/hwmon/aht10.c

   174	
   175	/**
   176	 * aht10_interval_write() - store the given minimum poll interval.
   177	 * Return: 0 on success, -EINVAL if a value lower than the
   178	 *         AHT10_MIN_POLL_INTERVAL is given
   179	 */
   180	static ssize_t aht10_interval_write(struct aht10_data *data,
   181					    long val)
 > 182	{
   183		data->min_poll_interval = ms_to_ktime(clamp_val(val, 2000, LONG_MAX));
   184		return 0;
   185	}
   186	
   187	/**
   188	 * aht10_interval_read() - read the minimum poll interval
   189	 *                            in milliseconds
   190	 */
   191	static ssize_t aht10_interval_read(struct aht10_data *data,
   192					   long *val)
 > 193	{
   194		*val = ktime_to_ms(data->min_poll_interval);
   195		return 0;
   196	}
   197	
   198	/**
   199	 * aht10_temperature1_read() - read the temperature in millidegrees
   200	 */
   201	static int aht10_temperature1_read(struct aht10_data *data, long *val)
 > 202	{
   203		int res;
   204	
   205		res = aht10_read_values(data);
   206		if (res < 0)
   207			return res;
   208	
   209		*val = data->temperature;
   210		return 0;
   211	}
   212	
   213	/**
   214	 * aht10_humidity1_read() - read the relative humidity in millipercent
   215	 */
   216	static int aht10_humidity1_read(struct aht10_data *data, long *val)
 > 217	{
   218		int res;
   219	
   220		res = aht10_read_values(data);
   221		if (res < 0)
   222			return res;
   223	
   224		*val = data->humidity;
   225		return 0;
   226	}
   227	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki