linux-kernel - Re: [PATCH v4 8/8] driver core: Move 2 one line device finding APIs to header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39bb2acb-b003-43b1-af6d-81c99f6b47eb@icloud.com>
Date: Tue, 24 Dec 2024 20:33:44 +0800
From: Zijun Hu <zijun_hu@...oud.com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>, Tejun Heo <tj@...nel.org>,
 Josef Bacik <josef@...icpanda.com>, Jens Axboe <axboe@...nel.dk>,
 Boris Burkov <boris@....io>, Davidlohr Bueso <dave@...olabs.net>,
 Dave Jiang <dave.jiang@...el.com>,
 Alison Schofield <alison.schofield@...el.com>,
 Vishal Verma <vishal.l.verma@...el.com>, Ira Weiny <ira.weiny@...el.com>,
 Dan Williams <dan.j.williams@...el.com>, linux-kernel@...r.kernel.org,
 cgroups@...r.kernel.org, linux-block@...r.kernel.org,
 linux-cxl@...r.kernel.org, Zijun Hu <quic_zijuhu@...cinc.com>
Subject: Re: [PATCH v4 8/8] driver core: Move 2 one line device finding APIs
 to header

On 2024/12/24 04:11, Jonathan Cameron wrote:
>> From: Zijun Hu <quic_zijuhu@...cinc.com>
>>
>> The following device finding APIs only have one line code in function body
>> device_find_child_by_name()
>> device_find_any_child()
>>
>> Move them to header as static inline function.
> Why drop the docs?
> 
thank you Jonathan for code review.

will add these comments back in next revision.

i do not notice the comments include important info, and think the API
name prompts what the API does, so remove the comments. my mistake.

>> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>