linux-kernel - Re: [PATCH v4 05/11] driver core: Simplify API device_find_child_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16a5d190-29b0-46f5-9845-a1d875211729@icloud.com>
Date: Tue, 24 Dec 2024 20:55:25 +0800
From: Zijun Hu <zijun_hu@...oud.com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski
 <brgl@...ev.pl>, Uwe Kleine-König <ukleinek@...nel.org>,
 James Bottomley <James.Bottomley@...senPartnership.com>,
 Thomas Weißschuh <thomas@...ch.de>,
 linux-kernel@...r.kernel.org, nvdimm@...ts.linux.dev,
 linux-sound@...r.kernel.org, sparclinux@...r.kernel.org,
 linux-block@...r.kernel.org, linux-cxl@...r.kernel.org,
 linux1394-devel@...ts.sourceforge.net, arm-scmi@...r.kernel.org,
 linux-efi@...r.kernel.org, linux-gpio@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, linux-mediatek@...ts.infradead.org,
 linux-hwmon@...r.kernel.org, linux-media@...r.kernel.org,
 linux-pwm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
 linux-scsi@...r.kernel.org, linux-usb@...r.kernel.org,
 linux-serial@...r.kernel.org, netdev@...r.kernel.org,
 Zijun Hu <quic_zijuhu@...cinc.com>
Subject: Re: [PATCH v4 05/11] driver core: Simplify API
 device_find_child_by_name() implementation

On 2024/12/24 04:39, Jonathan Cameron wrote:
> There is a subtle difference.  In theory old code could dereference a NULL
> if parent->p == NULL, now it can't.  Sounds at most like a harmless change but
> maybe you should mention it.
> 

i did not correct parameter checking for device_find_child_by_name() in
below commit

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/base/core.c?id=903c44939abc02e2f3d6f2ad65fa090f7e5df5b6

since this commit will come finally, actually, this commit is the
original motivation of this whole patch series.

> Otherwise LGTM
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>