linux-kernel - Re: [RFC PATCH 2/8] dt-bindings: mailbox: Add bindings for RPMI shared memory transport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAhSdy3n5HrYUUcA8QRUU96kCzFn8zkAZL+LQ7Up6Bk+68-cFQ@mail.gmail.com>
Date: Tue, 24 Dec 2024 08:37:39 +0530
From: Anup Patel <anup@...infault.org>
To: Leyfoon Tan <leyfoon.tan@...rfivetech.com>
Cc: Anup Patel <apatel@...tanamicro.com>, Michael Turquette <mturquette@...libre.com>, 
	Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Jassi Brar <jassisinghbrar@...il.com>, Palmer Dabbelt <palmer@...belt.com>, 
	Paul Walmsley <paul.walmsley@...ive.com>, Sunil V L <sunilvl@...tanamicro.com>, 
	Rahul Pathak <rpathak@...tanamicro.com>, Atish Patra <atishp@...shpatra.org>, 
	Andrew Jones <ajones@...tanamicro.com>, 
	"linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>, 
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, 
	"linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 2/8] dt-bindings: mailbox: Add bindings for RPMI
 shared memory transport

On Tue, Dec 24, 2024 at 7:49 AM Leyfoon Tan
<leyfoon.tan@...rfivetech.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Anup Patel <apatel@...tanamicro.com>
> > Sent: Monday, December 16, 2024 4:48 PM
> > To: Michael Turquette <mturquette@...libre.com>; Stephen Boyd
> > <sboyd@...nel.org>; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski
> > <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; Jassi Brar
> > <jassisinghbrar@...il.com>
> > Cc: Palmer Dabbelt <palmer@...belt.com>; Paul Walmsley
> > <paul.walmsley@...ive.com>; Sunil V L <sunilvl@...tanamicro.com>; Rahul
> > Pathak <rpathak@...tanamicro.com>; Leyfoon Tan
> > <leyfoon.tan@...rfivetech.com>; Atish Patra <atishp@...shpatra.org>;
> > Andrew Jones <ajones@...tanamicro.com>; Anup Patel
> > <anup@...infault.org>; linux-clk@...r.kernel.org;
> > devicetree@...r.kernel.org; linux-riscv@...ts.infradead.org; linux-
> > kernel@...r.kernel.org; Anup Patel <apatel@...tanamicro.com>
> > Subject: [RFC PATCH 2/8] dt-bindings: mailbox: Add bindings for RPMI shared
> > memory transport
> >
> [...]
>
> > +
> > +examples:
> > +  - |
> > +    // Example 1 (RPMI shared memory with only 2 queues):
> > +    mailbox@...80000 {
> > +        compatible = "riscv,rpmi-shmem-mbox";
> > +        reg = <0x00 0x10080000 0x00 0x10000>,
> > +              <0x00 0x10090000 0x00 0x10000>,
> > +              <0x00 0x100a0000 0x00 0x4>;
> > +        reg-names = "a2p-req", "p2a-ack", "db-reg";
> > +        msi-parent = <&imsic_mlevel>;
> > +        riscv,slot-size = <64>;
> > +        #mbox-cells = <1>;
> > +    };
> > +  - |
> > +    // Example 2 (RPMI shared memory with only 4 queues):
> > +    mailbox@...01000 {
> > +        compatible = "riscv,rpmi-shmem-mbox";
> > +        reg = <0x00 0x10001000 0x00 0x800>,
> > +              <0x00 0x10001800 0x00 0x800>,
> > +              <0x00 0x10002000 0x00 0x800>,
> > +              <0x00 0x10002800 0x00 0x800>,
> > +              <0x00 0x10003000 0x00 0x4>;
> > +        reg-names = "a2p-req", "p2a-ack", "db-reg";
>
> reg has 5 entries, missing 2 reg-names?

copy-paste error, thanks for catching.

Regards,
Anup

>
> > +        msi-parent = <&imsic_mlevel>;
> > +        riscv,slot-size = <64>;
> > +        riscv,db-mask = <0x00008000>;
> > +        riscv,db-value = <0x00008000>;
> > +        #mbox-cells = <1>;
> > +    };
> > --
> > 2.43.0
>
> Regards
> Ley Foon