linux-kernel - Re: [PATCH] cpufreq: sparc: change kzalloc to kcalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241224041949.ewmo3f5beyuoilsv@vireshk-i7>
Date: Tue, 24 Dec 2024 09:49:49 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: Ethan Carter Edwards <ethan@...ancedwards.com>
Cc: "rafael@...nel.org" <rafael@...nel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cpufreq: sparc: change kzalloc to kcalloc

On 23-12-24, 14:41, Ethan Carter Edwards wrote:
> Refactor to use kcalloc instead of kzalloc when multiplying
> allocation size by count. This refactor prevents unintentional
> memory overflows. Discovered by checkpatch.pl.
> 
> Signed-off-by: Ethan Carter Edwards <ethan@...ancedwards.com>
> ---
>  drivers/cpufreq/sparc-us2e-cpufreq.c | 2 +-
>  drivers/cpufreq/sparc-us3-cpufreq.c  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/sparc-us2e-cpufreq.c b/drivers/cpufreq/sparc-us2e-cpufreq.c
> index 8a0cd5312a59..15899dd77c08 100644
> --- a/drivers/cpufreq/sparc-us2e-cpufreq.c
> +++ b/drivers/cpufreq/sparc-us2e-cpufreq.c
> @@ -323,7 +323,7 @@ static int __init us2e_freq_init(void)
>  	impl  = ((ver >> 32) & 0xffff);
>  
>  	if (manuf == 0x17 && impl == 0x13) {
> -		us2e_freq_table = kzalloc(NR_CPUS * sizeof(*us2e_freq_table),
> +		us2e_freq_table = kcalloc(NR_CPUS, sizeof(*us2e_freq_table),
>  					 GFP_KERNEL);
>  		if (!us2e_freq_table)
>  			return -ENOMEM;
> diff --git a/drivers/cpufreq/sparc-us3-cpufreq.c b/drivers/cpufreq/sparc-us3-cpufreq.c
> index b50f9d13e6d2..de50a2f3b124 100644
> --- a/drivers/cpufreq/sparc-us3-cpufreq.c
> +++ b/drivers/cpufreq/sparc-us3-cpufreq.c
> @@ -171,7 +171,7 @@ static int __init us3_freq_init(void)
>  	    impl == CHEETAH_PLUS_IMPL ||
>  	    impl == JAGUAR_IMPL ||
>  	    impl == PANTHER_IMPL)) {
> -		us3_freq_table = kzalloc(NR_CPUS * sizeof(*us3_freq_table),
> +		us3_freq_table = kcalloc(NR_CPUS, sizeof(*us3_freq_table),
>  					GFP_KERNEL);
>  		if (!us3_freq_table)
>  			return -ENOMEM;

Applied. Thanks.

Though I failed to apply it directly using git/b4 for some reason, had
to manually make the updates and commit.

-- 
viresh