linux-kernel - Re: [PATCH v7 01/16] rust: module: add trait `ModuleMetadata`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241224205124.0f716b22.gary@garyguo.net>
Date: Tue, 24 Dec 2024 20:51:24 +0000
From: Gary Guo <gary@...yguo.net>
To: Danilo Krummrich <dakr@...nel.org>
Cc: gregkh@...uxfoundation.org, rafael@...nel.org, bhelgaas@...gle.com,
 ojeda@...nel.org, alex.gaynor@...il.com, boqun.feng@...il.com,
 bjorn3_gh@...tonmail.com, benno.lossin@...ton.me, tmgross@...ch.edu,
 a.hindborg@...sung.com, aliceryhl@...gle.com, airlied@...il.com,
 fujita.tomonori@...il.com, lina@...hilina.net, pstanner@...hat.com,
 ajanulgu@...hat.com, lyude@...hat.com, robh@...nel.org,
 daniel.almeida@...labora.com, saravanak@...gle.com,
 dirk.behme@...bosch.com, j@...nau.net, fabien.parent@...aro.org,
 chrisi.schrefl@...il.com, paulmck@...nel.org,
 rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pci@...r.kernel.org, devicetree@...r.kernel.org, rcu@...r.kernel.org
Subject: Re: [PATCH v7 01/16] rust: module: add trait `ModuleMetadata`

On Thu, 19 Dec 2024 18:04:03 +0100
Danilo Krummrich <dakr@...nel.org> wrote:

> In order to access static metadata of a Rust kernel module, add the
> `ModuleMetadata` trait.
> 
> In particular, this trait provides the name of a Rust kernel module as
> specified by the `module!` macro.
> 
> Signed-off-by: Danilo Krummrich <dakr@...nel.org>

Reviewed-by: Gary Guo <gary@...yguo.net>

> ---
>  rust/kernel/lib.rs    | 6 ++++++
>  rust/macros/module.rs | 4 ++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs
> index e1065a7551a3..61b82b78b915 100644
> --- a/rust/kernel/lib.rs
> +++ b/rust/kernel/lib.rs
> @@ -116,6 +116,12 @@ fn init(module: &'static ThisModule) -> impl init::PinInit<Self, error::Error> {
>      }
>  }
>  
> +/// Metadata attached to a [`Module`] or [`InPlaceModule`].
> +pub trait ModuleMetadata {
> +    /// The name of the module as specified in the `module!` macro.
> +    const NAME: &'static crate::str::CStr;
> +}
> +
>  /// Equivalent to `THIS_MODULE` in the C API.
>  ///
>  /// C header: [`include/linux/init.h`](srctree/include/linux/init.h)
> diff --git a/rust/macros/module.rs b/rust/macros/module.rs
> index 2587f41b0d39..cdf94f4982df 100644
> --- a/rust/macros/module.rs
> +++ b/rust/macros/module.rs
> @@ -228,6 +228,10 @@ pub(crate) fn module(ts: TokenStream) -> TokenStream {
>                  kernel::ThisModule::from_ptr(core::ptr::null_mut())
>              }};
>  
> +            impl kernel::ModuleMetadata for {type_} {{
> +                const NAME: &'static kernel::str::CStr = kernel::c_str!(\"{name}\");
> +            }}
> +
>              // Double nested modules, since then nobody can access the public items inside.
>              mod __module_init {{
>                  mod __module_init {{