linux-kernel - Re: [DMARC error][DKIM error]Re: [PATCH 3/3] clk: amlogic: s4: remove unused data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4e4808ee-07f2-43db-b7f8-e9362c9898e4@amlogic.com>
Date: Tue, 24 Dec 2024 13:20:14 +0800
From: Chuan Liu <chuan.liu@...ogic.com>
To: Dmitry Rokosov <ddrokosov@...utedevices.com>
Cc: Jerome Brunet <jbrunet@...libre.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Neil Armstrong <neil.armstrong@...aro.org>,
 Kevin Hilman <khilman@...libre.com>,
 Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
 linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-amlogic@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [DMARC error][DKIM error]Re: [PATCH 3/3] clk: amlogic: s4: remove
 unused data

hi Dmitry:


On 12/23/2024 5:01 PM, Dmitry Rokosov wrote:
> [You don't often get email from ddrokosov@...utedevices.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> [ EXTERNAL EMAIL ]
>
> Hello Chuan!
>
> On Mon, Dec 23, 2024 at 03:59:07PM +0800, Chuan Liu wrote:
>> Hi Jerome:
>>
>> Thank you for pointing out.
>>
>>
>> On 12/21/2024 1:17 AM, Jerome Brunet wrote:
>>> [ EXTERNAL EMAIL ]
>>>
>>> Following the removal of the big clk_regmap clock table from the
>>> s4-peripherals clock controller driver, it appears some clocks are unused,
>>> which means these are not exported or even registered.
>>
>> I have confirmed here that these clocks are used for the demodulator
>> of DTV (Digital Television). The DTV-related driver will use these
>> clocks.
>>
>>
>>> In all likelihood, these clocks have not been tested. Remove the unused
>>> clocks for now. These can added back later when they have been properly
>>> tested.
>>
>> I will complete these clocks later after testing.
> Are you planning to submit the DTV drivers that will utilize these
> clocks to the upstream?


I have learned that there is no plan for now. It is uncertain whether
it will be submitted upstream in the later stage.


>
> If I correctly interpret Jerome's patch series, it appears that these
> clocks will not be applied to the upstream kernel unless there are
> clients present in the future.


Jerome deleted these clocks because they were defined in the driver
but were not referenced and registered.

These clocks should be added to "s4d_hw_onecell_data" to be registered.
They were omitted when the driver was submitted previously.


> Please correct me if I'm wrong.
>
> [...]
>
> --
> Thank you,
> Dmitry