Message-ID: <75B06EE0B67747ED+20241225094202.597305-1-wangyuli@uniontech.com>
Date: Wed, 25 Dec 2024 17:42:02 +0800
From: WangYuli <wangyuli@...ontech.com>
To: viro@...iv.linux.org.uk,
	brauner@...nel.org,
	jack@...e.cz
Cc: linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	yushengjin@...ontech.com,
	zhangdandan@...ontech.com,
	guanwentao@...ontech.com,
	zhanjun@...ontech.com,
	oliver.sang@...el.com,
	ebiederm@...ssion.com,
	colin.king@...onical.com,
	josh@...htriplett.org,
	penberg@...helsinki.fi,
	manfred@...orfullife.com,
	mingo@...e.hu,
	jes@....com,
	hch@....de,
	aia21@...tab.net,
	arjan@...radead.org,
	jgarzik@...ox.com,
	neukum@...hschaft.cup.uni-muenchen.de,
	oliver@...kum.name,
	dada1@...mosbay.com,
	axboe@...nel.dk,
	axboe@...e.de,
	nickpiggin@...oo.com.au,
	dhowells@...hat.com,
	nathans@....com,
	rolandd@...co.com,
	tytso@....edu,
	bunk@...sta.de,
	pbadari@...ibm.com,
	ak@...ux.intel.com,
	ak@...e.de,
	davem@...emloft.net,
	jsipek@...sunysb.edu,
	jens.axboe@...cle.com,
	ramsdell@...re.org,
	hch@...radead.org,
	torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org,
	randy.dunlap@...cle.com,
	efault@....de,
	rdunlap@...radead.org,
	haveblue@...ibm.com,
	drepper@...hat.com,
	dm.n9107@...il.com,
	jblunck@...e.de,
	davidel@...ilserver.org,
	mtk.manpages@...glemail.com,
	linux-arch@...r.kernel.org,
	vda.linux@...glemail.com,
	jmorris@...ei.org,
	serue@...ibm.com,
	hca@...ux.ibm.com,
	rth@...ddle.net,
	lethal@...ux-sh.org,
	tony.luck@...el.com,
	heiko.carstens@...ibm.com,
	oleg@...hat.com,
	andi@...stfloor.org,
	corbet@....net,
	crquan@...il.com,
	mszeredi@...e.cz,
	miklos@...redi.hu,
	peterz@...radead.org,
	a.p.zijlstra@...llo.nl,
	earl_chew@...lent.com,
	npiggin@...il.com,
	npiggin@...e.de,
	julia@...u.dk,
	jaxboe@...ionio.com,
	nikai@...ai.net,
	dchinner@...hat.com,
	davej@...hat.com,
	npiggin@...nel.dk,
	eric.dumazet@...il.com,
	tim.c.chen@...ux.intel.com,
	xemul@...allels.com,
	tj@...nel.org,
	serge.hallyn@...onical.com,
	gorcunov@...nvz.org,
	levinsasha928@...il.com,
	penberg@...nel.org,
	amwang@...hat.com,
	bcrl@...ck.org,
	muthu.lkml@...il.com,
	muthur@...il.com,
	mjt@....msk.ru,
	alan@...rguk.ukuu.org.uk,
	raven@...maw.net,
	thomas@...3r.de,
	will.deacon@....com,
	will@...nel.org,
	josef@...hat.com,
	anatol.pomozov@...il.com,
	koverstreet@...gle.com,
	zab@...hat.com,
	balbi@...com,
	gregkh@...uxfoundation.org,
	mfasheh@...e.com,
	jlbec@...lplan.org,
	rusty@...tcorp.com.au,
	asamymuthupa@...ron.com,
	smani@...ron.com,
	sbradshaw@...ron.com,
	jmoyer@...hat.com,
	sim@...tway.ca,
	ia@...udflare.com,
	dmonakhov@...nvz.org,
	ebiggers3@...il.com,
	socketpair@...il.com,
	penguin-kernel@...ove.SAKURA.ne.jp,
	w@....eu,
	kirill.shutemov@...ux.intel.com,
	mhocko@...e.com,
	vdavydov.dev@...il.com,
	vdavydov@...tuozzo.com,
	hannes@...xchg.org,
	mhocko@...nel.org,
	minchan@...nel.org,
	deepa.kernel@...il.com,
	arnd@...db.de,
	balbi@...nel.org,
	swhiteho@...hat.com,
	konishi.ryusuke@....ntt.co.jp,
	dsterba@...e.com,
	vegard.nossum@...cle.com,
	axboe@...com,
	pombredanne@...b.com,
	tglx@...utronix.de,
	joe.lawrence@...hat.com,
	mpatocka@...hat.com,
	mcgrof@...nel.org,
	keescook@...omium.org,
	linux@...inikbrodowski.net,
	jannh@...gle.com,
	shakeelb@...gle.com,
	guro@...com,
	willy@...radead.org,
	khlebnikov@...dex-team.ru,
	kirr@...edi.com,
	stern@...land.harvard.edu,
	elver@...gle.com,
	parri.andrea@...il.com,
	paulmck@...nel.org,
	rasibley@...hat.com,
	jstancek@...hat.com,
	avagin@...il.com,
	cai@...hat.com,
	josef@...icpanda.com,
	hare@...e.de,
	colyli@...e.de,
	johannes@...solutions.net,
	sspatil@...roid.com,
	alex_y_xu@...oo.ca,
	mgorman@...hsingularity.net,
	gor@...ux.ibm.com,
	jhubbard@...dia.com,
	andriy.shevchenko@...ux.intel.com,
	crope@....fi,
	yzaikin@...gle.com,
	bfields@...ldses.org,
	jlayton@...nel.org,
	kernel@...force.de,
	steve@....org,
	nixiaoming@...wei.com,
	0x7f454c46@...il.com,
	kuniyu@...zon.co.jp,
	alexander.h.duyck@...el.com,
	kuni1840@...il.com,
	soheil@...gle.com,
	sridhar.samudrala@...el.com,
	Vincenzo.Frascino@....com,
	chuck.lever@...cle.com,
	Kevin.Brodsky@....com,
	Szabolcs.Nagy@....com,
	David.Laight@...LAB.com,
	Mark.Rutland@....com,
	linux-morello@...lists.linaro.org,
	Luca.Vizzarro@....com,
	max.kellermann@...os.com,
	adobriyan@...il.com,
	lukas@...auer.dev,
	j.granados@...sung.com,
	djwong@...nel.org,
	kent.overstreet@...ux.dev,
	linux@...ssschuh.net,
	kstewart@...icios.com,
	WangYuli <wangyuli@...ontech.com>
Subject: [RESEND PATCH] fs/pipe: Introduce a check to skip sleeping processes during pipe read/write

When a user calls the read/write system call and passes a pipe
descriptor, the pipe_read/pipe_write functions are invoked:

1. pipe_read():
  1). Checks if the pipe is valid and if there is any data in the
pipe buffer.
  2). Waits for data:
    *If there is no data in the pipe and the write end is still open,
the current process enters a sleep state (wait_event()) until data
is written.
    *If the write end is closed, return 0.
  3). Reads data:
    *Wakes up the process and copies data from the pipe's memory
buffer to user space.
    *When the buffer is full, the writing process will go to sleep,
waiting for the pipe state to change to be awakened (using the
wake_up_interruptible_sync_poll() mechanism). Once data is read
from the buffer, the writing process can continue writing, and the
reading process can continue reading new data.
  4). Returns the number of bytes read upon successful read.

2. pipe_write():
  1). Checks if the pipe is valid and if there is any available
space in the pipe buffer.
  2). Waits for buffer space:
    *If the pipe buffer is full and the reading process has not
read any data, pipe_write() may put the current process to sleep
until there is space in the buffer.
    *If the read end of the pipe is closed (no process is waiting
to read), an error code -EPIPE is returned, and a SIGPIPE signal may
be sent to the process.
  3). Writes data:
    *If there is enough space in the pipe buffer, pipe_write() copies
data from the user space buffer to the kernel buffer of the pipe
(using copy_from_user()).
    *If the amount of data the user requests to write is larger than
the available space in the buffer, multiple writes may be required,
or the process may wait for new space to be freed.
  4). Wakes up waiting reading processes:
    *After the data is successfully written, pipe_write() wakes up
any processes that may be waiting to read data (using the
wake_up_interruptible_sync_poll() mechanism).
  5). Returns the number of bytes successfully written.

Check if there are any waiting processes in the process wait queue
by introducing wq_has_sleeper() when waking up processes for pipe
read/write operations.

If no processes are waiting, there's no need to execute
wake_up_interruptible_sync_poll(), thus avoiding unnecessary wake-ups.

Unnecessary wake-ups can lead to context switches, where a process
is woken up to handle I/O events even when there is no immediate
need.

Only wake up processes when there are actually waiting processes to
reduce context switches and system overhead by checking
with wq_has_sleeper().

Additionally, by reducing unnecessary synchronization and wake-up
operations, wq_has_sleeper() can decrease system resource waste and
lock contention, improving overall system performance.

For pipe read/write operations, this eliminates ineffective scheduling
and enhances concurrency.

It's important to note that enabling this option means invoking
wq_has_sleeper() to check for sleeping processes in the wait queue
for every read or write operation.

While this is a lightweight operation, it still incurs some overhead.

In low-load or single-task scenarios, this overhead may not yield
significant benefits and could even introduce minor performance
degradation.

UnixBench Pipe benchmark results on Zhaoxin KX-U6780A processor:

With the option disabled: Single-core: 841.8, Multi-core (8): 4621.6
With the option enabled:  Single-core: 877.8, Multi-core (8): 4854.7

Single-core performance improved by 4.1%, multi-core performance
improved by 4.8%.

Co-developed-by: Shengjin Yu <yushengjin@...ontech.com>
Signed-off-by: Shengjin Yu <yushengjin@...ontech.com>
Co-developed-by: Dandan Zhang <zhangdandan@...ontech.com>
Signed-off-by: Dandan Zhang <zhangdandan@...ontech.com>
Tested-by: Dandan Zhang <zhangdandan@...ontech.com>
Signed-off-by: WangYuli <wangyuli@...ontech.com>
---
 fs/Kconfig | 13 +++++++++++++
 fs/pipe.c  | 21 +++++++++++++++------
 2 files changed, 28 insertions(+), 6 deletions(-)

diff --git a/fs/Kconfig b/fs/Kconfig
index 64d420e3c475..0dacc46a73fe 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -429,4 +429,17 @@ source "fs/unicode/Kconfig"
 config IO_WQ
 	bool
 
+config PIPE_SKIP_SLEEPER
+	bool "Skip sleeping processes during pipe read/write"
+	default n
+	help
+	  This option introduces a check whether the sleep queue will
+	  be awakened during pipe read/write.
+
+	  It often leads to a performance improvement. However, in
+	  low-load or single-task scenarios, it may introduce minor
+	  performance overhead.
+
+	  If unsure, say N.
+
 endmenu
diff --git a/fs/pipe.c b/fs/pipe.c
index 12b22c2723b7..c085333ae72c 100644
--- a/fs/pipe.c
+++ b/fs/pipe.c
@@ -247,6 +247,15 @@ static inline unsigned int pipe_update_tail(struct pipe_inode_info *pipe,
 	return tail;
 }
 
+static inline bool
+pipe_check_wq_has_sleeper(struct wait_queue_head *wq_head)
+{
+	if (IS_ENABLED(CONFIG_PIPE_SKIP_SLEEPER))
+		return wq_has_sleeper(wq_head);
+	else
+		return true;
+}
+
 static ssize_t
 pipe_read(struct kiocb *iocb, struct iov_iter *to)
 {
@@ -377,7 +386,7 @@ pipe_read(struct kiocb *iocb, struct iov_iter *to)
 		 * _very_ unlikely case that the pipe was full, but we got
 		 * no data.
 		 */
-		if (unlikely(was_full))
+		if (unlikely(was_full) && pipe_check_wq_has_sleeper(&pipe->wr_wait))
 			wake_up_interruptible_sync_poll(&pipe->wr_wait, EPOLLOUT | EPOLLWRNORM);
 		kill_fasync(&pipe->fasync_writers, SIGIO, POLL_OUT);
 
@@ -398,9 +407,9 @@ pipe_read(struct kiocb *iocb, struct iov_iter *to)
 		wake_next_reader = false;
 	mutex_unlock(&pipe->mutex);
 
-	if (was_full)
+	if (was_full && pipe_check_wq_has_sleeper(&pipe->wr_wait))
 		wake_up_interruptible_sync_poll(&pipe->wr_wait, EPOLLOUT | EPOLLWRNORM);
-	if (wake_next_reader)
+	if (wake_next_reader && pipe_check_wq_has_sleeper(&pipe->rd_wait))
 		wake_up_interruptible_sync_poll(&pipe->rd_wait, EPOLLIN | EPOLLRDNORM);
 	kill_fasync(&pipe->fasync_writers, SIGIO, POLL_OUT);
 	if (ret > 0)
@@ -573,7 +582,7 @@ pipe_write(struct kiocb *iocb, struct iov_iter *from)
 		 * become empty while we dropped the lock.
 		 */
 		mutex_unlock(&pipe->mutex);
-		if (was_empty)
+		if (was_empty && pipe_check_wq_has_sleeper(&pipe->rd_wait))
 			wake_up_interruptible_sync_poll(&pipe->rd_wait, EPOLLIN | EPOLLRDNORM);
 		kill_fasync(&pipe->fasync_readers, SIGIO, POLL_IN);
 		wait_event_interruptible_exclusive(pipe->wr_wait, pipe_writable(pipe));
@@ -598,10 +607,10 @@ pipe_write(struct kiocb *iocb, struct iov_iter *from)
 	 * Epoll nonsensically wants a wakeup whether the pipe
 	 * was already empty or not.
 	 */
-	if (was_empty || pipe->poll_usage)
+	if ((was_empty || pipe->poll_usage) && pipe_check_wq_has_sleeper(&pipe->rd_wait))
 		wake_up_interruptible_sync_poll(&pipe->rd_wait, EPOLLIN | EPOLLRDNORM);
 	kill_fasync(&pipe->fasync_readers, SIGIO, POLL_IN);
-	if (wake_next_writer)
+	if (wake_next_writer && pipe_check_wq_has_sleeper(&pipe->wr_wait))
 		wake_up_interruptible_sync_poll(&pipe->wr_wait, EPOLLOUT | EPOLLWRNORM);
 	if (ret > 0 && sb_start_write_trylock(file_inode(filp)->i_sb)) {
 		int err = file_update_time(filp);
-- 
2.45.2

Powered by blists - more mailing lists