linux-kernel - RE: [PATCH V4 1/2] dmaengine: fsl-edma: cleanup chan after dma_async_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB84594DAC406C20E711A4F558880C2@PAXPR04MB8459.eurprd04.prod.outlook.com>
Date: Wed, 25 Dec 2024 01:00:35 +0000
From: Peng Fan <peng.fan@....com>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>, Frank Li <frank.li@....com>,
	Vinod Koul <vkoul@...nel.org>, "open list:FREESCALE eDMA DRIVER"
	<imx@...ts.linux.dev>, "open list:FREESCALE eDMA DRIVER"
	<dmaengine@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH V4 1/2] dmaengine: fsl-edma: cleanup chan after
 dma_async_device_unregister

> Subject: [PATCH V4 1/2] dmaengine: fsl-edma: cleanup chan after
> dma_async_device_unregister

Ping..

Thanks,
Peng.

> 
> From: Peng Fan <peng.fan@....com>
> 
> There is kernel dump when do module test:
> sysfs: cannot create duplicate filename
> /devices/platform/soc@...4000000.bus/44000000.dma-
> controller/dma/dma0chan0
>  __dma_async_device_channel_register+0x128/0x19c
>  dma_async_device_register+0x150/0x454
>  fsl_edma_probe+0x6cc/0x8a0
>  platform_probe+0x68/0xc8
> 
> fsl_edma_cleanup_vchan will unlink vchan.chan.device_node, while
> dma_async_device_unregister  needs the link to do
> __dma_async_device_channel_unregister. So need move
> fsl_edma_cleanup_vchan after dma_async_device_unregister to make
> sure channel could be freed.
> 
> So clean up chan after dma_async_device_unregister to address this.
> 
> Fixes: 6f93b93b2a1b ("dmaengine: fsl-edma: kill the tasklets upon exit")
> Reviewed-by: Frank Li <Frank.Li@....com>
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---