linux-kernel - Re: [RESEND PATCH] arm/pgtable: Remove duplicate included header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z2wLt6V1zwtGnJYk@kernel.org>
Date: Wed, 25 Dec 2024 15:42:15 +0200
From: Mike Rapoport <rppt@...nel.org>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Russell King <linux@...linux.org.uk>,
	David Hildenbrand <david@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] arm/pgtable: Remove duplicate included header file

On Wed, Dec 25, 2024 at 01:30:35PM +0100, Thorsten Blum wrote:
> The header file asm-generic/pgtable-nopud.h is included whether
> CONFIG_MMU is defined or not.
> 
> Include it only once before the #ifndef/#else/#endif preprocessor
> directives and remove the following make includecheck warning:
> 
>   asm-generic/pgtable-nopud.h is included more than once
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>

Reviewed-by: Mike Rapoport (Microsoft) <rppt@...nel.org>

> ---
>  arch/arm/include/asm/pgtable.h | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h
> index be91e376df79..6b986ef6042f 100644
> --- a/arch/arm/include/asm/pgtable.h
> +++ b/arch/arm/include/asm/pgtable.h
> @@ -19,14 +19,13 @@ extern struct page *empty_zero_page;
>  #define ZERO_PAGE(vaddr)	(empty_zero_page)
>  #endif
>  
> -#ifndef CONFIG_MMU
> -
>  #include <asm-generic/pgtable-nopud.h>
> +
> +#ifndef CONFIG_MMU
>  #include <asm/pgtable-nommu.h>
>  
>  #else
>  
> -#include <asm-generic/pgtable-nopud.h>
>  #include <asm/page.h>
>  #include <asm/pgtable-hwdef.h>
>  
> -- 
> 2.47.1
> 

-- 
Sincerely yours,
Mike.