[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Z2tNebOEpysqVBBF@slm.duckdns.org>
Date: Tue, 24 Dec 2024 14:10:33 -1000
From: Tejun Heo <tj@...nel.org>
To: Ihor Solodrai <ihor.solodrai@...me>
Cc: David Vernet <void@...ifault.com>, sched-ext@...a.com,
kernel-team@...a.com, linux-kernel@...r.kernel.org,
bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH sched_ext/for-6.13-fixes] sched_ext: Fix dsq_local_on
selftest
On Tue, Dec 24, 2024 at 02:09:15PM -1000, Tejun Heo wrote:
> The dsp_local_on selftest expects the scheduler to fail by trying to
> schedule an e.g. CPU-affine task to the wrong CPU. However, this isn't
> guaranteed to happen in the 1 second window that the test is running.
> Besides, it's odd to have this particular exception path tested when there
> are no other tests that verify that the interface is working at all - e.g.
> the test would pass if dsp_local_on interface is completely broken and fails
> on any attempt.
>
> Flip the test so that it verifies that the feature works. While at it, fix a
> typo in the info message.
>
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Reported-by: Ihor Solodrai <ihor.solodrai@...me>
> Link: http://lkml.kernel.org/r/Z1n9v7Z6iNJ-wKmq@slm.duckdns.org
Applied to sched_ext/for-6.13-fixes.
Thanks.
--
tejun
Powered by blists - more mailing lists